Skip to content

netdev: add TX feedback events #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2015
Merged

netdev: add TX feedback events #3729

merged 1 commit into from
Oct 12, 2015

Conversation

daniel-k
Copy link
Member

This PR adds additional transmission feedback events for the (now) old netdev interface with a sample implementation for the at86rf2xx driver.

@daniel-k daniel-k added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking labels Aug 27, 2015
@daniel-k daniel-k mentioned this pull request Aug 27, 2015
Closed
@PeterKietzmann
Copy link
Member

Maybe a job for @thomaseichinger ?

@haukepetersen
Copy link
Contributor

The changes look good to me, although I won't have time to test this. @thomaseichinger, would you mind :-)

@daniel-k daniel-k added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Aug 28, 2015
@thomaseichinger
Copy link
Member

Changes look legit, will test this on Monday.

@thomaseichinger thomaseichinger added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 28, 2015
@daniel-k
Copy link
Member Author

@thomaseichinger ping

@OlegHahm
Copy link
Member

He didn't say which Monday... ;-)

@thomaseichinger
Copy link
Member

@daniel-k sorry for the delay. I didn't forget about these changes, will test as soon as possible.

@daniel-k
Copy link
Member Author

No worries, just wanted to check on this again :-) Seems you guys are still involved with the release I guess ...

@daniel-k daniel-k mentioned this pull request Sep 24, 2015
Closed
@daniel-k
Copy link
Member Author

daniel-k commented Oct 9, 2015

@thomaseichinger ping

@thomaseichinger
Copy link
Member

thomaseichinger commented Oct 9, 2015 via email

@thomaseichinger
Copy link
Member

Great, works nicely as expected. Please squash.

@thomaseichinger thomaseichinger added this to the Release NEXT MAJOR milestone Oct 12, 2015
@daniel-k daniel-k force-pushed the net_at86rf2xx_tx_feedback branch from f4cb427 to 9c36546 Compare October 12, 2015 13:51
@daniel-k daniel-k removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Oct 12, 2015
@daniel-k
Copy link
Member Author

@thomaseichinger
Squashed and travis is green. Thanks for reviewing :)

@thomaseichinger
Copy link
Member

Nice job, ACK & Go.

thomaseichinger added a commit that referenced this pull request Oct 12, 2015
@thomaseichinger
Merge pull request #3729 from daniel-k/net_at86rf2xx_tx_feedback
7bf1219 
netdev: add TX feedback events
@thomaseichinger thomaseichinger merged commit 7bf1219 into RIOT-OS:master Oct 12, 2015
@daniel-k daniel-k deleted the net_at86rf2xx_tx_feedback branch October 12, 2015 15:39
@daniel-k daniel-k mentioned this pull request Oct 25, 2015
Closed
@miri64 miri64 mentioned this pull request Oct 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomaseichinger thomaseichinger

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2015.12
Development

Successfully merging this pull request may close these issues.
5 participants
@daniel-k @PeterKietzmann @haukepetersen @thomaseichinger @OlegHahm