Skip to content

makefiles/tools/esptool: force installation of version 4.9.0 #21604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

makefiles/tools/esptool: force installation of version 4.9.0 #21604

merged 1 commit into from
Jul 16, 2025

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR pins the installation of the esptool.py Python package to version 4.9.0 also for flashing.

A couple of days ago, Espressif released version 5.0.0 of esptool.py and uploaded the corresponding Python package. While esptool.py installation was pinned to version v4.9.0 for compilation by PR #21588, esptool.py version v5.0.0 is still used for flashing. As a result, esptools.py is installed again and again alternating between v4.9.0 and v5.0.0.

This PR fixes this problem.

Testing procedure

Try to compile an flash any application for any ESP32 board, for example:

BOARD=esp32-wroom-32 make -C tests/sys/shell flash

Without the PR, epstool.py is installed again and again and the flash target throws a number of deprecation warnings. With the PR esptool.py is installed only once, the first time it is needed.

Issues/PRs references

Fixes PR #21588

@github-actions github-actions bot added Area: build system Area: Build system Area: tools Area: Supplementary tools labels Jul 15, 2025
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 15, 2025
@gschorcht gschorcht enabled auto-merge July 15, 2025 12:39
@gschorcht
Copy link
Contributor Author

Thanks for the approval.

@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Jul 15, 2025
@riot-ci
Copy link

riot-ci commented Jul 15, 2025

Murdock results

✔️ PASSED

998b2d6 makefiles/tools/esptool: force installation of version 4.9.0

Success Failures Total Runtime
1 0 1 01m:14s

Artifacts

@gschorcht gschorcht added this pull request to the merge queue Jul 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 15, 2025
@gschorcht gschorcht added this pull request to the merge queue Jul 15, 2025
@gschorcht gschorcht mentioned this pull request Jul 16, 2025
Merged
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 16, 2025
@crasbe crasbe added this pull request to the merge queue Jul 16, 2025
@gschorcht
Copy link
Contributor Author

gschorcht commented Jul 16, 2025 •
edited
Loading

This was the second time that the PR has been removed from the merge queue due to no response for status checks.

Is there something wrong with the CI?
Why does this PR need a full build in Murdock? This PR only affects the flashing of a board.

@crasbe
Copy link
Contributor

crasbe commented Jul 16, 2025

This was the second time that the PR has been removed from the merge queue due to no response for status checks.

Is there something wrong with the CI? Why does this PR need a full build in Murdock? This PR only affects the flashing of a board.

The issue with the CI system is that the merging takes too long and the github-merge-queue has a timeout. Currently mobi6 and skyleaf are offline, which is why it takes so long.

The timeout only happens in certain unlucky constellations. I hope skyleaf will be back before the weekend and mobi6 should've already been back, not sure when it'll be back.

Merged via the queue into RIOT-OS:master with commit d06b61d Jul 16, 2025
31 checks passed
@gschorcht gschorcht deleted the pkg/esptool_fix_version_for_flash branch July 30, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @riot-ci @crasbe @benpicco