tests/unittests: Add missing module dependency to enable UDP #21597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did this not show up in the CI before? 🤔 |
|
Because the CI likely built a bunch of things in one go, hiding this bug. E.g. if you do |
crasbe
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Hello 🦋,
this fixes an issue where the unit test
tests-sock_utilcould not be compiled as types were left undefined.Testing procedure
make -C tests/unittests/ tests-sock_util flash-only testIssues/PRs references
Possibly introduced by either "pragma once" breaking (fixing) a header include or by #21419 which guards transitive header explicitly.