pkg/nanopb: support more recent google.protobuf versions #21587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crasbe
reviewed
Jul 9, 2025
|
check-commits doesn't like the format of the commits, please use |
35df963 to
7430920
Compare
- update test in tests/pkg/nanopb to detect recent google.protobuf changes - test still runs with google.protobuf 4.21.12 - test now fails with google.protobuf 6.31.1 due to removal of deprecated api parts
- fixes usage with recent google.protobuf versions - tested with versions: 4.21.12, 6.31.1
7430920 to
53ac0ef
Compare
crasbe
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR bumps the nanopb version to a more recent tag to support recent versions of the google.protobuf python library.
Testing procedure
Test in tests/pkg/nanopb is modified in the first commit to fail for recent versions of google protobuf (v6.31.1 tested).
The second commit bumps nanopb to fix this issue and has been tested with google protobuf versions v4.21.12 and v6.31.1. You might need to
rm -rf binin addition to make clean when switching the python library.Issues/PRs references
None.