Skip to content

boards/nucleo-l412kb: improve board doc page #21554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

boards/nucleo-l412kb: improve board doc page #21554

merged 3 commits into from
Jun 19, 2025

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

This PR updates nucleo-l412kb board doc page, by:

Testing procedure

Generate doc and check if everything looks good:

make doc
xdg-open ./doc/doxygen/html/group__boards__nucleo-l412kb.html

Issues/PRs references

PR #21255.

@krzysztof-cabaj krzysztof-cabaj requested a review from aabadie as a code owner June 18, 2025 08:22
@github-actions github-actions bot added Area: doc Area: Documentation Area: boards Area: Board ports labels Jun 18, 2025
benpicco
benpicco reviewed Jun 18, 2025
View reviewed changes
boards/nucleo-l412kb/doc.md Outdated

| MCU | STM32L412KB |
|:---------- |:------------------- |
| Family | ARM Cortex-M4 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Family | ARM Cortex-M4 |
| Family | ARM Cortex-M4F |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

One question. Do you think all ARM Cortex-M4 with FPU should have family Cortex-M4F?
I'm not 100% sure - but have a feeling that there is some mismatch in some CPU tables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Cortex M4 with a FPU is a Cortex M4F.

@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jun 18, 2025
@riot-ci
Copy link

riot-ci commented Jun 18, 2025

Murdock results

✔️ PASSED

236c129 boards/nucleo-l412kb: add MCU table to doc page

Success Failures Total Runtime
1 0 1 01m:22s

Artifacts

@benpicco benpicco enabled auto-merge June 19, 2025 10:01
@benpicco benpicco added this pull request to the merge queue Jun 19, 2025
Merged via the queue into RIOT-OS:master with commit ce7a3b5 Jun 19, 2025
31 checks passed
This was referenced Jun 23, 2025
Merged
Closed
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
5 participants
@krzysztof-cabaj @riot-ci @benpicco @crasbe @Teufelchen1