Skip to content

sys/event/deferred_callback: disable timer before modifying event #21539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jun 4, 2025

Contribution description

Remove the event from the timer queue before modifying it's contents.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added the Area: sys Area: System label Jun 4, 2025
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a rebase too.

@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 4, 2025
@crasbe
Copy link
Contributor

crasbe commented Jun 4, 2025

Is this a bug or an enhancement? 🤔

@riot-ci
Copy link

riot-ci commented Jun 4, 2025

Murdock results

✔️ PASSED

845deae sys/event/deferred_callback: disable timer before modifying event

Success Failures Total Runtime
10379 0 10379 15m:11s

Artifacts

@benpicco benpicco force-pushed the event_deferred_callback_post-fix branch from 3b61afa to 845deae Compare June 13, 2025 15:39
@benpicco benpicco added this pull request to the merge queue Jun 19, 2025
Merged via the queue into RIOT-OS:master with commit 8590133 Jun 19, 2025
25 checks passed
@benpicco benpicco deleted the event_deferred_callback_post-fix branch June 19, 2025 17:23
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants