Skip to content

examples/gnrc_lorawan: simplyfy configuration a bit #21526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

examples/gnrc_lorawan: simplyfy configuration a bit #21526

merged 1 commit into from
Jun 27, 2025

Conversation

fabian18
Copy link
Contributor

@fabian18 fabian18 commented Jun 3, 2025

Contribution description

I struggled a bit to figure out what to set and what to enable for examples/networking/gnrc/gnrc_lorawan.
I would consider this a tiny clean up. Maybe you agree.

Testing procedure

Issues/PRs references

split out from #21202

@github-actions github-actions bot added the Area: examples Area: Example Applications label Jun 3, 2025
@crasbe crasbe added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 3, 2025
mguetschow
mguetschow reviewed Jun 3, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me. However, the README reads to me as if the decision for OTAA or ABP can be done at run-time, and this Makefile reads like it would be a compile-time decision. Could you clarify? (I have no prior knowledge with lorawan)

@fabian18
Copy link
Contributor Author

fabian18 commented Jun 3, 2025

Both can be used in one binary but there is one default.

https://github.com/fabian18/RIOT/blob/ed44a434641ff0516a01fea885c5e32625beb558/sys/include/net/loramac.h#L442-L447

The else in the Makefile should then probably only choose the default.

OTAA can be disabled at runtime in which case the default becomes ABP.

https://github.com/fabian18/RIOT/blob/ed44a434641ff0516a01fea885c5e32625beb558/sys/net/gnrc/netif/lorawan/gnrc_netif_lorawan.c#L550-L583

mguetschow
mguetschow approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, please squash :)

@fabian18 fabian18 force-pushed the pr/examples_gnrc_lorawan_cleaner_config branch from b12445a to 53520dd Compare June 3, 2025 12:53
@riot-ci
Copy link

riot-ci commented Jun 3, 2025 •
edited
Loading

Murdock results

✔️ PASSED

5222ef5 examples/gnrc_lorawan: simplyfy configuration a bit

Success Failures Total Runtime
19 0 19 02m:33s

Artifacts

@mguetschow mguetschow added this pull request to the merge queue Jun 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2025
@benpicco benpicco added this pull request to the merge queue Jun 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2025
@benpicco
Copy link
Contributor

Looks like this will need a rebase for static-tests to pass.

@fabian18 fabian18 force-pushed the pr/examples_gnrc_lorawan_cleaner_config branch from 53520dd to 5222ef5 Compare June 27, 2025 12:39
@crasbe crasbe enabled auto-merge June 27, 2025 13:30
@crasbe crasbe added this pull request to the merge queue Jun 27, 2025
Merged via the queue into RIOT-OS:master with commit 94029df Jun 27, 2025
25 checks passed
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

Assignees
No one assigned
Labels
Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
6 participants
@fabian18 @riot-ci @benpicco @mguetschow @crasbe @Teufelchen1