-
Notifications
You must be signed in to change notification settings - Fork 2.1k
treewide: migrate to XFA SHELL_COMMAND #21514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The changes introduce some line length static errors, most of them can probably be avoided. |
Ah, fun - XFA commands seem to be sorted differently in Since we are not testing the shell here, I'd just remove the test for |
You might want to check https://github.com/RIOT-OS/RIOT/blob/master/tests/sys/shell/tests/01-run.py which checks the help independent of the order of the listing, if you want to keep the help check. But then again: The help function is tested by that test already, so there is not too much to gain from testing the help output here again. |
Should be all fixed now. |
d3cd236
to
6abf12f
Compare
Thanks for your review and approval :) |
Contribution description
Migrate some more applications to using the XFA SHELL_COMMAND instead of the statically allocated list (often with
extern
function declarations) inmain.c
.Testing procedure
CI should find build regressions.
Issues/PRs references
Follow-up of #21171