Skip to content

treewide: migrate to XFA SHELL_COMMAND #21514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025

Conversation

mguetschow
Copy link
Contributor

Contribution description

Migrate some more applications to using the XFA SHELL_COMMAND instead of the statically allocated list (often with extern function declarations) in main.c.

Testing procedure

CI should find build regressions.

Issues/PRs references

Follow-up of #21171

@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: examples Area: Example Applications labels May 27, 2025
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 27, 2025
@crasbe crasbe added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label May 27, 2025
@crasbe
Copy link
Contributor

crasbe commented May 27, 2025

The changes introduce some line length static errors, most of them can probably be avoided.

@riot-ci
Copy link

riot-ci commented May 27, 2025

Murdock results

✔️ PASSED

6abf12f tests/sys/struct_tm_utility: do not test shell help command

Success Failures Total Runtime
322 0 324 03m:05s

Artifacts

@mguetschow
Copy link
Contributor Author

Ah, fun - XFA commands seem to be sorted differently in help depending on the toolchain used: https://ci.riot-os.org/details/df348a5877e2481faf8ca0d24a1ee997/tests/tests:sys:struct_tm_utility

Since we are not testing the shell here, I'd just remove the test for help from the script.

@maribu
Copy link
Member

maribu commented May 28, 2025

You might want to check https://github.com/RIOT-OS/RIOT/blob/master/tests/sys/shell/tests/01-run.py which checks the help independent of the order of the listing, if you want to keep the help check.

But then again: The help function is tested by that test already, so there is not too much to gain from testing the help output here again.

@mguetschow
Copy link
Contributor Author

The changes introduce some line length static errors, most of them can probably be avoided.

Should be all fixed now.

@mguetschow mguetschow force-pushed the shell-commands-xfa branch from d3cd236 to 6abf12f Compare June 2, 2025 07:41
@mguetschow mguetschow enabled auto-merge June 2, 2025 07:41
@mguetschow mguetschow added this pull request to the merge queue Jun 2, 2025
Merged via the queue into RIOT-OS:master with commit 6fc81ad Jun 2, 2025
25 checks passed
@mguetschow mguetschow deleted the shell-commands-xfa branch June 2, 2025 09:55
@mguetschow
Copy link
Contributor Author

Thanks for your review and approval :)

@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants