Skip to content

makefiles/defaultmodules*.mk: fix the description in comments #21499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

makefiles/defaultmodules*.mk: fix the description in comments #21499

merged 1 commit into from
May 19, 2025

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented May 19, 2025 •
edited
Loading

Contribution description

This PR is a small correction of the comments in makefiles/defaultmodules*.inc which were a bit confusing, especially in makefiles/defaultmodules_no_recursive_deps.inc.mk.

Testing procedure

Review of the comments.

Issues/PRs references

@github-actions github-actions bot added the Area: build system Area: Build system label May 19, 2025
@gschorcht gschorcht force-pushed the makefiles/defaultmodules_fix branch from ed6630c to 0c96a69 Compare May 19, 2025 10:59
mguetschow
mguetschow approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mguetschow mguetschow added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels May 19, 2025
@mguetschow mguetschow enabled auto-merge May 19, 2025 11:02
@riot-ci
Copy link

riot-ci commented May 19, 2025

Murdock results

✔️ PASSED

0c96a69 makefiles/defaultmodules: fix comments

Success Failures Total Runtime
1 0 1 01m:13s

Artifacts

@mguetschow mguetschow added this pull request to the merge queue May 19, 2025
@crasbe crasbe added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label May 19, 2025
Merged via the queue into RIOT-OS:master with commit 790626e May 19, 2025
29 checks passed
@gschorcht
Copy link
Contributor Author

@mguetschow Thanks for reviewing an merging.

@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
@gschorcht gschorcht deleted the makefiles/defaultmodules_fix branch July 30, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
5 participants
@gschorcht @riot-ci @mguetschow @crasbe @Teufelchen1