Murdock results

✔️ PASSED

12cc737 boards/seeedstudio-xiao-esp32c3: fix Arduino pins

Artifacts

• Documentation preview

Wouldn't a similar approach to #21338 work here as well? The Nucleo64 boards have the same issue with a conflicting pin between the LED and SPI bus.

Wouldn't a similar approach to #21338 work here as well? The Nucleo64 boards have the same issue with a conflicting pin between the LED and SPI bus.

Yes, indeed. I tried to mimic this behavior. What do you think?

The drivers/max31865: implement LUT generator script commit does not really belong to this PR, does it? 😅

@gschorcht you still have your "changes requested" review open that prevents merging.

Thank you for sticking through, even though the approach was changed and there were a lot of suggestions :)

You're welcome. I learned a new RIOT trick 😄

You shouldn't use URLs for references inside the documentation. Furthermore, ESP32 documentation includes its own section on application specific configurations. Using CFLAGS at command line or in the Makefile of the application should be much more easier than to override board.h.

@gschorcht The changes you request here are not relevant any more, due to the solution suggested by @crasbe, which differs substantially from my initial proposition.

@dpproto Please use fixups the next time and wait until a maintainer asks you to squash the PR. This helps to track the requested changes.

Sorry for being a bit nitpicky. It might be that doxygen is not happy with this kind of macro guards having a doc but not the define. Why don't you just embed all the definitions related to the button in the directive, including all the documentation? It makes no sense to define BTN0_MODE or BTN0_INT_FLANK if the button is not defined. The easiest way would be:

#if MODULE_PERIPH_INIT_BUTTONS || DOXYGEN
/**
 * @name    Button pin definitions
 * @{
 */
...
/** @} */
#endif

With this approach you have only one #ifdef ... #endif and doxygen is happy.

Sorry for being a bit nitpicky. It might be that doxygen is not happy with this kind of macro guards having a doc but not the define. Why don't you just embed all the definitions related to the button in the directive, including all the documentation? It makes no sense to define BTN0_MODE or BTN0_INT_FLANK if the button is not defined. The easiest way would be:

#if MODULE_PERIPH_INIT_BUTTONS || DOXYGEN
/**
 * @name    Button pin definitions
 * @{
 */
...
/** @} */
#endif

With this approach you have only one #ifdef ... #endif and doxygen is happy.

I also found Doxygen warning for undocumented items in include/arduino_iomap.h and made a 3rd commit for that.

I also found Doxygen warning for undocumented items in include/arduino_iomap.h and made a 3rd commit for that.

👍 But again, please use fixups for existing commits 😉

I also found Doxygen warning for undocumented items in include/arduino_iomap.h and made a 3rd commit for that.

👍 But again, please use fixups for existing commits 😉

So, git commit --amend won't do if I fix the last commit?

So, git commit --amend won't do if I fix the last commit?

With git commit --amend you can add or replace files of an existing commit, but it replaces the commit instead of creating a new commit with the differences to the existing commit. The right command would be git commit --fixup.