Skip to content

sys/psa_crypto: Adding ecc p256r1 pub key derivation #21461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2025
Merged

sys/psa_crypto: Adding ecc p256r1 pub key derivation #21461

merged 4 commits into from
May 27, 2025

Conversation

Lukas-Luger
Copy link
Contributor

Contribution description

This PR adds public key derivation for P256R1 curves using the micro-ecc backend. Unfortunately the Cryptocell 310 does not support this operation.

Testing procedure

The existing test at tests/sys/psa_crypto_ecdsa has been extended to verify the key derivation.

Issues/PRs references

None

@github-actions github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: pkg Area: External package ports Area: sys Area: System labels May 4, 2025
@Teufelchen1 Teufelchen1 requested a review from Einhornhool May 6, 2025 08:40
Teufelchen1
Teufelchen1 reviewed May 6, 2025
View reviewed changes
Teufelchen1
Teufelchen1 reviewed May 6, 2025
View reviewed changes
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 6, 2025
@riot-ci
Copy link

riot-ci commented May 6, 2025 •
edited
Loading

Murdock results

✔️ PASSED

a932a4e tests/sys/psa_crypto_ecdsa: add pub key derivation

Success Failures Total Runtime
10362 0 10363 14m:55s

Artifacts

mguetschow
mguetschow reviewed May 9, 2025
View reviewed changes
@mguetschow
Copy link
Contributor

Quoting Murdock

In file included from psa_crypto_algorithm_dispatch.c:34:
include/psa_ecc.h:99:35: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[in]       priv_key_buffer
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
include/psa_ecc.h:100:34: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[out]      pub_key_buffer
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
include/psa_ecc.h:101:42: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[in]       priv_key_buffer_length
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
include/psa_ecc.h:102:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[inout]    pub_key_buffer_length
         ^~~~~~~
include/psa_ecc.h:102:41: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param[inout]    pub_key_buffer_length
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
5 errors generated.

mguetschow
mguetschow approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please squash :)

@Lukas-Luger Lukas-Luger force-pushed the pr/psa-ecc-pub-key-derivation branch from 087603b to a932a4e Compare May 27, 2025 06:42
@mguetschow mguetschow added this pull request to the merge queue May 27, 2025
Merged via the queue into RIOT-OS:master with commit 0124fdc May 27, 2025
25 checks passed
@Lukas-Luger Lukas-Luger deleted the pr/psa-ecc-pub-key-derivation branch May 27, 2025 13:07
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 left review comments

@mguetschow mguetschow mguetschow approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@Einhornhool Einhornhool Awaiting requested review from Einhornhool

Assignees
No one assigned
Labels
Area: doc Area: Documentation Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
5 participants
@Lukas-Luger @riot-ci @mguetschow @Teufelchen1 @crasbe