Skip to content

sys/net/sockutil: Do not use undefined structs #21467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

sys/net/sockutil: Do not use undefined structs #21467

merged 1 commit into from
May 6, 2025

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented May 6, 2025 •
edited
Loading

Contribution description

sock_tcp_ep_t may not be defined if sock_tcp is not used.

Testing procedure

make -C examples/networking/coap/gcoap LWIP_IPV4=1 works again

Issues/PRs references

fixes #21419

@benpicco
sys/net/sockutil: Do not use undefined structs
a08a081 
sock_tcp_ep_t may not be defined if sock_tcp is not used.
@benpicco benpicco requested a review from maribu as a code owner May 6, 2025 13:06
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels May 6, 2025
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 6, 2025
@benpicco benpicco mentioned this pull request May 6, 2025
Merged
@riot-ci
Copy link

riot-ci commented May 6, 2025

Murdock results

✔️ PASSED

a08a081 sys/net/sockutil: Do not use undefined structs

Success Failures Total Runtime
10337 0 10337 11m:05s

Artifacts

@maribu maribu enabled auto-merge May 6, 2025 13:27
@maribu maribu added this pull request to the merge queue May 6, 2025
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label May 6, 2025
@crasbe crasbe added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label May 6, 2025
Merged via the queue into RIOT-OS:master with commit 8f96147 May 6, 2025
29 checks passed
@krzysztof-cabaj krzysztof-cabaj mentioned this pull request May 6, 2025
Merged
@benpicco benpicco deleted the sock_util-fix branch May 6, 2025 16:29
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @riot-ci @maribu @crasbe @Teufelchen1