build system: improve cargo/docker interaction #21465
Merged
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not create the cargo folder unconditionally, but only before running docker and only when they do not exist.
kfessel
reviewed
May 6, 2025
There was a problem hiding this comment.
strange warning about make trying to create a directory in root is gone
also did a build with docker RIOT/examples/basic/default/ > make ..in-docker-container and it created a .cargo in my home dir << that seems strange to me (creating a unneeded (for default-example) random directory) but by the wording of the makefile this seems intended ( I would think directories like this would be contained in RIOT/build)
benpicco
approved these changes
May 6, 2025
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Do not create the cargo folder unconditionally, but only before running docker and only when they do not exist.
Testing procedure
without
.cargo/gitand.cargo/registryshould create those folders before running docker, so that they are not created as root.Issues/PRs references
None