Skip to content

sys/event: make debug output of event_loop_debug more useful #21456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

sys/event: make debug output of event_loop_debug more useful #21456

merged 1 commit into from
Apr 30, 2025

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Apr 30, 2025 •
edited
Loading

Contribution description

Callback events will always have _event_callback_handler() as their callback function, which is not very useful.

Detect them and print the debut output in _event_callback_handler() instead to make for some more useful debug output.

Testing procedure

Enable the event_loop_debug module.

025-04-30 14:44:05,875 # main(): This is RIOT! (Version: 2025.07-devel-97-gaf6bc9)
2025-04-30 14:44:05,876 # event: executing 0x416b20->0x402646(0x409983)
2025-04-30 14:44:05,877 # event 0
2025-04-30 14:44:05,878 # event: 0x416b20 took 7 µs
2025-04-30 14:44:05,878 # event: executing 0x416be8->0x402646(0x409993)
2025-04-30 14:44:05,879 # event A
2025-04-30 14:44:05,880 # event: 0x416be8 took 26 µs
2025-04-30 14:44:05,880 # event: executing 0x416b40->0x402646(0x40998b)
2025-04-30 14:44:05,881 # event D
2025-04-30 14:44:05,881 # event: 0x416b40 took 17 µs
2025-04-30 14:44:05,882 # event: executing 0x416c68->0x402646(0x40999b)
2025-04-30 14:44:05,883 # event B
2025-04-30 14:44:05,883 # event: 0x416c68 took 18 µs
2025-04-30 14:44:05,884 # event: executing 0x416be8->0x402646(0x409993)
2025-04-30 14:44:05,884 # event A
2025-04-30 14:44:05,885 # event: 0x416be8 took 14 µs
2025-04-30 14:44:06,371 # event: executing 0x416ce8->0x402646(0x4099a3)
2025-04-30 14:44:06,371 # event C
2025-04-30 14:44:06,372 # event: 0x416ce8 took 24 µs
2025-04-30 14:44:06,377 # event: executing 0x416be8->0x402646(0x409993)
2025-04-30 14:44:06,378 # event A
2025-04-30 14:44:06,379 # event: 0x416be8 took 23 µs
2025-04-30 14:44:06,872 # event: executing 0x416c68->0x402646(0x40999b)
2025-04-30 14:44:06,873 # event B
2025-04-30 14:44:06,873 # event: 0x416c68 took 24 µs
2025-04-30 14:44:06,878 # event: executing 0x416be8->0x402646(0x409993)
2025-04-30 14:44:06,879 # event A
2025-04-30 14:44:06,880 # event: 0x416be8 took 31 µs
2025-04-30 14:44:07,380 # event: executing 0x416be8->0x402646(0x409993)
2025-04-30 14:44:07,381 # event A
2025-04-30 14:44:07,381 # event: 0x416be8 took 24 µs
2025-04-30 14:44:07,870 # event: executing 0x416ce8->0x402646(0x4099a3)
2025-04-30 14:44:07,871 # event C
2025-04-30 14:44:07,872 # event: 0x416ce8 took 25 µs
2025-04-30 14:44:07,873 # event: executing 0x416c68->0x402646(0x40999b)
2025-04-30 14:44:07,874 # event B
2025-04-30 14:44:07,875 # event: 0x416c68 took 22 µs
2025-04-30 14:44:07,883 # event: executing 0x416be8->0x402646(0x409993)
2025-04-30 14:44:07,883 # event A
2025-04-30 14:44:07,884 # event: 0x416be8 took 30 µs

Issues/PRs references

follow-up to #20849

@benpicco benpicco requested a review from kaspar030 as a code owner April 30, 2025 12:46
@github-actions github-actions bot added the Area: sys Area: System label Apr 30, 2025
@benpicco benpicco requested review from maribu and removed request for kaspar030 April 30, 2025 12:48
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 30, 2025
@riot-ci
Copy link

riot-ci commented Apr 30, 2025

Murdock results

✔️ PASSED

26ddb2e sys/event: make debug output of event_loop_debug more useful

Success Failures Total Runtime
10320 0 10320 12m:31s

Artifacts

@benpicco benpicco added this pull request to the merge queue Apr 30, 2025
Merged via the queue into RIOT-OS:master with commit c3ac00c Apr 30, 2025
27 checks passed
@benpicco benpicco deleted the event_callback_debug branch April 30, 2025 15:41
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @maribu @Teufelchen1