Skip to content

sys/bcd: add bcd_buf_to_u32() and bcd_buf_from_str() #21428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

sys/bcd: add bcd_buf_to_u32() and bcd_buf_from_str() #21428

merged 2 commits into from
Apr 26, 2025

Conversation

benpicco
Copy link
Contributor

Contribution description

Add functions to

  • convert a BCD buffer to a uint32_t/uint64_t
  • parse a string as BCD buffer

Testing procedure

Unit-tests have been added for the new functions.

Issues/PRs references

@benpicco benpicco requested a review from miri64 as a code owner April 23, 2025 17:23
@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: sys Area: System labels Apr 23, 2025
@benpicco benpicco force-pushed the sys/bcd_buf_from_str branch 2 times, most recently from d470fa9 to 9c709f2 Compare April 23, 2025 17:24
@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 23, 2025
crasbe
crasbe reviewed Apr 23, 2025
View reviewed changes
@riot-ci
Copy link

riot-ci commented Apr 23, 2025 •
edited
Loading

Murdock results

✔️ PASSED

444fc84 tests/unittests: add tests for bcd_buf_to_u32() and bcd_buf_from_str()

Success Failures Total Runtime
10320 0 10320 12m:49s

Artifacts

@benpicco benpicco force-pushed the sys/bcd_buf_from_str branch from 9c709f2 to 1c22d0a Compare April 24, 2025 11:47
crasbe
crasbe reviewed Apr 25, 2025
View reviewed changes
@benpicco benpicco force-pushed the sys/bcd_buf_from_str branch from 1c22d0a to 529fcf6 Compare April 25, 2025 10:04
@benpicco benpicco force-pushed the sys/bcd_buf_from_str branch from 529fcf6 to 444fc84 Compare April 25, 2025 16:48
@maribu maribu added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2025
@crasbe crasbe added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2025
@crasbe crasbe added this pull request to the merge queue Apr 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2025
@maribu maribu added this pull request to the merge queue Apr 26, 2025
@maribu maribu removed this pull request from the merge queue due to a manual request Apr 26, 2025
@maribu maribu added this pull request to the merge queue Apr 26, 2025
@kaspar030 kaspar030 removed this pull request from the merge queue due to a manual request Apr 26, 2025
@kaspar030 kaspar030 added this pull request to the merge queue Apr 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2025
@maribu maribu added this pull request to the merge queue Apr 26, 2025
Merged via the queue into RIOT-OS:master with commit a862dc6 Apr 26, 2025
27 checks passed
@maribu
Copy link
Member

maribu commented Apr 26, 2025

The CI glitches were pushing back hard on this one :-/ Good to have this overcome now :)

@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crasbe crasbe crasbe approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @riot-ci @maribu @crasbe @Teufelchen1