boards/adafruit-{clue,itsybitsy-nrf52}: Convert to Common adafruit-nrf52-bootloader module
#21395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought about this some more and it probably doesn't make sense to do that. The value |
The Adafruit Clue and Itsybitsy nRF52 also use the Adafruit nRF52 Bootloader which has a common module that can be used. Especially the Itsybitsy nRF52 (mis)uses the nrfutil programmer target and has a lot of redundant code. Furthermore, the Double Tap Magic Value used by both boards is incorrect for using the USB Bootloader.
maribu
approved these changes
May 7, 2025
|
@maribu let me know if the new change satisfies you, then we can merge (or you hit the merge button if you're happy). |
|
Thank you for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The aim of this PR is twofold:
It would be nice to not have the SoftDevice version hard-coded, which prevents using the
adafruit-nrfutilwith boards such as theseeedstudio-xiao-nrf52840(-sense).Migrate the only two boards using the
adafruit-nrfutilto the commonboards_common_adafruit-nrf52-bootloader.In the process, the Makefile of the
adafruit-itsybitsy-nrf52can be decluttered, a lot of duplicate code is present and it abuses thenrfutilprogrammer target.2a) Change the default bootloader to
uf2conv.The Magic Double Tap values of the Clue and Itsybitsy-nRF52 don't enable the MSD feature which
uf2convwould use, so they are in-factadafruit-nrfutilonly.Open Discussion Points: The Clue and Itsybitsy-nRF52 should work with
uf2convas well, that would drop the requirement to installadafruit-nrfutil, which has it's own quirks...ToDos:
1) Change the documentation to hint to the common Adafruit nRF52 Bootloader documentation in both thedoc.txtof the clue and itsybitsy as well as the common Flashing documentation: doc/doxygen/src/flashing.md2) Make the commonreset.cmore universal so that different Magic Double Tap values can be set (0x4Efor theadafruit-nrfutiland0x57foruf2conv).Testing procedure
BOARD=adafruit-clue make -C tests/sys/shell flash termshould still work. If you don't have a Clue or Itsybitsy-nRF52, you can flash the Adafruit nRF52 Bootloader to an nRF52840DK as well.Issues/PRs references
None.