Skip to content

buildsystem: Fix Supported Board List in info-build #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

buildsystem: Fix Supported Board List in info-build #21361

merged 1 commit into from
Apr 4, 2025

Conversation

crasbe
Copy link
Contributor

@crasbe crasbe commented Apr 4, 2025 •
edited
Loading

Contribution description

@mguetschow documented in #21019 that the info-build target does not show the all the boards that are actually supported, depending on the board that is set on the command line.

The reason for this is that the Make system creates a lot of environment variables and hands them down to the next instance. In this case, the FEATURES_REQUIRED variable was set and had some requirements that not all of the supported boards could fulfill, therefore they were (errorneously) sorted out.

Therefore this PR starts the submake in a clean environment, so that Make is not influenced by what's set by the parent.

Testing procedure

With master:

$ BOARD=feather-nrf52840-sense make -C tests/drivers/nrf802154 info-build 
...
supported boards:
adafruit-clue adafruit-itsybitsy-nrf52 arduino-nano-33-ble arduino-nano-33-ble-sense feather-nrf52840 feather-nrf52840-sense nrf52840-mdk-dongle nrf52840dongle particle-argon particle-boron particle-xenon
...

With this PR:

$ BOARD=feather-nrf52840-sense make -C tests/drivers/nrf802154 info-build 
...
supported boards:
adafruit-clue adafruit-itsybitsy-nrf52 arduino-nano-33-ble arduino-nano-33-ble-sense e104-bt5011a-tb feather-nrf52840 feather-nrf52840-sense microbit-v2 nrf52840-mdk nrf52840-mdk-dongle nrf52840dk nrf52840dongle particle-argon particle-boron particle-xenon reel seeedstudio-xiao-nrf52840 seeedstudio-xiao-nrf52840-sense waveshare-nrf52840-eval-kit
...

Issues/PRs references

Fixes #21019.

@crasbe crasbe added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 4, 2025
@crasbe crasbe requested a review from mguetschow April 4, 2025 09:47
@github-actions github-actions bot added the Area: build system Area: Build system label Apr 4, 2025
mguetschow
mguetschow reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for looking into this! 🤗

@crasbe crasbe force-pushed the pr/fix-info-build branch from fd5a853 to 7169214 Compare April 4, 2025 10:47
@crasbe crasbe mentioned this pull request Apr 4, 2025
Merged
mguetschow
mguetschow approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@mguetschow mguetschow enabled auto-merge April 4, 2025 13:05
@riot-ci
Copy link

riot-ci commented Apr 4, 2025

Murdock results

✔️ PASSED

7169214 buildsystem: fix supported boards in info-build

Success Failures Total Runtime
10277 0 10279 10m:49s

Artifacts

@mguetschow mguetschow added this pull request to the merge queue Apr 4, 2025
@crasbe
Copy link
Contributor Author

crasbe commented Apr 4, 2025

Great, thanks for looking into this! 🤗

You're welcome. I learned a lot about Make again and it's nice when there's a simple fix.

Merged via the queue into RIOT-OS:master with commit c0c61e1 Apr 4, 2025
27 checks passed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2025.04
Development

Successfully merging this pull request may close these issues.

build system: issues with reporting supported boards
3 participants
@crasbe @riot-ci @mguetschow