dist/tools: add #pragma once to headerguard check
#21367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enoch247
reviewed
Apr 6, 2025
Enoch247
approved these changes
Apr 6, 2025
7c250d0 to
bf1491e
Compare
|
Thanks for reviewing :) |
|
Thanks for doing this! We still have to update our coding convention and templates we may have somewhere. |
Indeed. I wanted to update the static-check first, so that it won't cause false failures in the migration process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The headerguards static check currently does not know anything about
#pragma once. However in #21335, the consensus was reached to use#pragma once, the static test should not fail for it.Testing procedure
#pragma onceto a header of your choice that already has the classic include guards (without removing them): the static test./dist/tools/headerguard/check.shshould fail../dist/tools/headerguard/check.shshould not fail.Issues/PRs references