sys/include: fix headers for clang-format #21340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Murdock results❌ FAILED 2ecaaaa sys/include: fix headers for clang-format Build failures (1)
Artifacts |
mguetschow
requested changes
Apr 1, 2025
Comment on lines
+8
to
+14
| #ifndef RIOTBOOT_BOOTLOADER_SELECTION_H | ||
| #define RIOTBOOT_BOOTLOADER_SELECTION_H | ||
|
|
||
| /* Include guards and cplusplus are more of a formality; this header is local | ||
| * to the riotboot_dfu application that isn't written in C++ and not included | ||
| * from anywhere else either, but still here for consistency (and because | ||
| * otherwise the checks complain) */ |
There was a problem hiding this comment.
Suggested change
| #ifndef RIOTBOOT_BOOTLOADER_SELECTION_H | |
| #define RIOTBOOT_BOOTLOADER_SELECTION_H | |
| /* Include guards and cplusplus are more of a formality; this header is local | |
| * to the riotboot_dfu application that isn't written in C++ and not included | |
| * from anywhere else either, but still here for consistency (and because | |
| * otherwise the checks complain) */ | |
| #ifndef RIOTBOOT_BOOTLOADER_SELECTION_H | |
| #define RIOTBOOT_BOOTLOADER_SELECTION_H | |
| /* Include guards and cplusplus are more of a formality; this header is local | |
| * to the riotboot_dfu application that isn't written in C++ and not included | |
| * from anywhere else either, but still here for consistency (and because | |
| * otherwise the checks complain) */ | |
Comment on lines
+11
to
+13
| #ifndef SUIT_TRANSPORT_WORKER_H | ||
| #define SUIT_TRANSPORT_WORKER_H | ||
|
|
There was a problem hiding this comment.
this one is copied, not moved. That should fix the failing test.
|
Let's put this on hold according to #21335 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is part of the greater effort to fix the headers according to #21335. It only covers the header files in sys/include.
I needed to edit some (~10) files manually. So before merging this needs to be checked. I receive some CI errors @mguetschow.