Skip to content

psa_crypto: fold some long lines #21303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

mcr
Copy link
Contributor

@mcr mcr commented Mar 17, 2025

Contribution description

This should be a do-nothing, change nothing PR that just shortens long lines so that the static tests do not spuriously complain.

Testing procedure

Compiled and ran the tests/sys/psa_crypto_hashes test case.

Issues/PRs references

The complaints showed up in PR #21297.

@github-actions github-actions bot added the Area: sys Area: System label Mar 17, 2025
@mcr mcr requested review from Einhornhool, chrysn and miri64 March 17, 2025 11:26
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 17, 2025
@mguetschow
Copy link
Contributor

CI finds four more lines, would you mind folding them too?

@riot-ci
Copy link

riot-ci commented Mar 17, 2025

Murdock results

✔️ PASSED

44cb7f1 psa_crypto: shorten @brief description, (not wrappable)

Success Failures Total Runtime
10269 0 10269 10m:47s

Artifacts

@mcr
Copy link
Contributor Author

mcr commented Mar 18, 2025 via email

@mcr
Copy link
Contributor Author

mcr commented Mar 18, 2025

mguetschow @.***> wrote: CI finds four more lines, would you mind folding them too? Yes, I was waiting for CI to complain to me, but that's why I wanted to run the CI check manually :-)

I am uncertain if @brief doxygen lines can be wrapped. I could not find any clear detail yet.
Another complaint seems to be that a file is too long????

@mcr mcr force-pushed the psa-crypto-long-line-fix branch 2 times, most recently from bf2e3f3 to f08c570 Compare March 18, 2025 10:55
@mguetschow
Copy link
Contributor

Run ./dist/tools/commit-msg/check.sh "master"
Error: Commit message is longer than 72 characters: "psa_crypto: shorten @brief description, as those lines can not be wrapped"

Congrats, now you hit the commit message length restriction :P

@mcr
Copy link
Contributor Author

mcr commented Mar 19, 2025

CI finds four more lines, would you mind folding them too?

I think that I got them all.
I edited the @brief to make it shorter, since I don't think I can wrap it.
I hope @Einhornhool will review that part to agree.

DeJusten and others added 3 commits March 19, 2025 13:24
In the description the compiler switch -D is missing for setting the
corresponding macro.
@mcr mcr force-pushed the psa-crypto-long-line-fix branch from f08c570 to 44cb7f1 Compare March 19, 2025 06:25
@github-actions github-actions bot added the Area: doc Area: Documentation label Mar 19, 2025
@mcr
Copy link
Contributor Author

mcr commented Mar 19, 2025

Run ./dist/tools/commit-msg/check.sh "master"
Error: Commit message is longer than 72 characters: "psa_crypto: shorten @brief description, as those lines can not be wrapped"

Congrats, now you hit the commit message length restriction :P

rewrote it.

Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🫰

@Teufelchen1
Copy link
Contributor

bit annoyed by the malloc_monitor commit not fitting in...but I guess I can just look away and we all get stuff done :>

@Teufelchen1 Teufelchen1 added this pull request to the merge queue Mar 19, 2025
Merged via the queue into RIOT-OS:master with commit 6192b35 Mar 19, 2025
26 checks passed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants