Skip to content

boards: set native variant depending on the host's CPU architecture #21291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

OlegHahm
Copy link
Member

@OlegHahm OlegHahm commented Mar 12, 2025

Contribution description

This patch renames the current native board into native32 and creates an de facto alias via the Makesystem dependent on the host system's architecture (kudos to @benpicco).

The changeset is mostly renaming directories and replacing native64 with native32 within application Makefiles (unless native64) was not supported.

It's mostly untested so far. Let's see what the CI comes up with.

Testing procedure

Use your favorite RIOT application on native.

Issues/PRs references

Alternativ variant to #21100

@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: tools Area: Supplementary tools Area: boards Area: Board ports Area: sys Area: System Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration labels Mar 12, 2025
@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 12, 2025
@OlegHahm OlegHahm force-pushed the pr/native_host_arch_dependent branch from 495d7a8 to e91ca21 Compare March 12, 2025 23:27
@riot-ci
Copy link

riot-ci commented Mar 12, 2025

Murdock results

FAILED

83eaa7f tests: external_board: use native64 as base

Success Failures Total Runtime
4130 0 9681 04m:49s

Artifacts

Moving the common code from the former boards/native into a common directory.
@OlegHahm OlegHahm force-pushed the pr/native_host_arch_dependent branch from 75ed8e4 to c20e9a5 Compare March 13, 2025 13:11
@mguetschow
Copy link
Contributor

Oh, I've been working on #21242 with a more generic alias approach. Not fully ready yet, sorry for not tagging you there.

@mguetschow
Copy link
Contributor

But I do like the idea of moving common native code to boards/common. Maybe we can combine both approaches?

@OlegHahm
Copy link
Member Author

Oh, I missed that one indeed. What are we gonna do? Do you want to try to cherry-pick the native-common stuff and I'm gonna close this one?

@mguetschow
Copy link
Contributor

Oh, I missed that one indeed. What are we gonna do? Do you want to try to cherry-pick the native-common stuff and I'm gonna close this one?

Yes, sounds good, I'll give it a try.

@mguetschow
Copy link
Contributor

Integrated in and discontinued in favor of #21242

@mguetschow mguetschow closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: doc Area: Documentation Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants