Skip to content

boards: introduce stdio_default #21294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 21, 2025
Merged

boards: introduce stdio_default #21294

merged 6 commits into from
Mar 21, 2025

Conversation

benpicco
Copy link
Contributor

Contribution description

Much like netdev_default or vfs_default, this adds a pseudo-module stdio_default with which boards can define their preferred method of doing stdio.

Testing procedure

examples/networking/misc/telnet_server is updated to select the telnet stdio method in addition to the default stdio method.

Issues/PRs references

@benpicco benpicco requested a review from gschorcht as a code owner March 13, 2025 15:15
@github-actions github-actions bot added Platform: native Platform: This PR/issue effects the native platform Area: build system Area: Build system Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports Area: examples Area: Example Applications labels Mar 13, 2025
mguetschow
mguetschow reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like a nice cleanup!

However, I'd expect much more boards (all of them?) currently defaulting to some stdio provider, and this PR only changes a handful of boards. Why is that so?

@mguetschow mguetschow mentioned this pull request Mar 14, 2025
Open
benpicco
benpicco commented Mar 19, 2025
View reviewed changes
@mguetschow
Copy link
Contributor

However, I'd expect much more boards (all of them?) currently defaulting to some stdio provider, and this PR only changes a handful of boards. Why is that so?

ping @benpicco

@benpicco
Copy link
Contributor Author

makefiles/stdio.inc.mk still exists and will select stdio_uart if no other stdio method has been selected

@mguetschow
Copy link
Contributor

Ah I see, something worth mentioning in the to-be-added documentation for stdio_default, I guess :)

@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 21, 2025
@riot-ci
Copy link

riot-ci commented Mar 21, 2025

Murdock results

✔️ PASSED

5025900 examples/telnet_server: select stdio_default

Success Failures Total Runtime
10269 0 10269 11m:05s

Artifacts

mguetschow
mguetschow reviewed Mar 21, 2025
View reviewed changes
benpicco
benpicco commented Mar 21, 2025
View reviewed changes
mguetschow
mguetschow approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then, thanks!

@mguetschow mguetschow added this pull request to the merge queue Mar 21, 2025
Merged via the queue into RIOT-OS:master with commit f3dbed4 Mar 21, 2025
30 checks passed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Milestone
Release 2025.04
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @mguetschow @riot-ci