Skip to content

Pkg/ccn-lite: use latest ccn-lite commit #21279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Pkg/ccn-lite: use latest ccn-lite commit #21279

merged 1 commit into from
Mar 10, 2025

Conversation

IsikcanYilmaz
Copy link
Contributor

Contribution description

Currently, when RIOT pulls the ccn-lite package, it gets the commit that's one before the latest, and then applies some patches. one of those patches is the exact same change that the package repo itself got, which is the latest commit of ccn-lite.

This change makes it so that RIOT uses that commit instead, and removes the patch.

the newest commit of the ccn-lite repo in question: 74568442b48b1154719fce8210d9974d75537502

Testing procedure

the file changed by the patch was ccnl-relay.c. one can look at the diff on it.

compile the ccn-lite-relay example.

Issues/PRs references

@github-actions github-actions bot added the Area: pkg Area: External package ports label Mar 7, 2025
@crasbe
Copy link
Contributor

crasbe commented Mar 7, 2025

One small remark: Please change the commit message according to our Commit Convention: https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions

Something like pkg/ccn-lite: use top of tree of ccnl and remove unneeded patch

Other than that the change looks pretty uncritical, but I'll let another maintainer have the final decision.

@IsikcanYilmaz IsikcanYilmaz force-pushed the pkg/ccn-lite_use_latest_ccnl branch from 7fe9533 to fa30a74 Compare March 7, 2025 19:52
@IsikcanYilmaz
Copy link
Contributor Author

One small remark: Please change the commit message according to our Commit Convention: https://github.com/RIOT-OS/RIOT/blob/master/CONTRIBUTING.md#commit-conventions

Something like pkg/ccn-lite: use top of tree of ccnl and remove unneeded patch

Other than that the change looks pretty uncritical, but I'll let another maintainer have the final decision.

done. yeah fairly uncritical. been dealing with ccnl and this would help with the tedium.

@crasbe crasbe added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 7, 2025
@riot-ci
Copy link

riot-ci commented Mar 7, 2025

Murdock results

✔️ PASSED

fa30a74 pkg/ccn-lite: use top of tree of ccnl and remove unneeded patch

Success Failures Total Runtime
10271 0 10271 10m:29s

Artifacts

@crasbe
Copy link
Contributor

crasbe commented Mar 7, 2025

I confirmed that the commit versions match and that the PR in ccn-lite does exactly what the patch did, so yeah, this seems all good. It compiles locally without any issues as well. CI is also happy.

For the next PR it would be good to add the full path to the example in the testing instructions. For reference: it is located in examples/networking/misc/ccn-lite-relay.
While you are probably very familiar with it, the maintainers might not be so I just had to search for it 😅

@IsikcanYilmaz
Copy link
Contributor Author

I confirmed that the commit versions match and that the PR in ccn-lite does exactly what the patch did, so yeah, this seems all good. It compiles locally without any issues as well. CI is also happy.

For the next PR it would be good to add the full path to the example in the testing instructions. For reference: it is located in examples/networking/misc/ccn-lite-relay. While you are probably very familiar with it, the maintainers might not be so I just had to search for it 😅

shoot sorry, the new example dir structure is ...new to me :D didnt think of this

@mguetschow mguetschow added this pull request to the merge queue Mar 10, 2025
Merged via the queue into RIOT-OS:master with commit 54d51b4 Mar 10, 2025
27 checks passed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2025.04
Development

Successfully merging this pull request may close these issues.
4 participants
@IsikcanYilmaz @crasbe @riot-ci @mguetschow