Skip to content

Conversation

crasbe
Copy link
Contributor

@crasbe crasbe commented Feb 27, 2025

Contribution description

As described in Issue #21220, many doc.txt files use the comment block of Doxygen incorrectly, possibly leading to weird side effects with asterisks used for bold/italic/...
The example in the Porting Boards tutorial also has the incorrect comment block style and this PR aims to fix that.

Current Master:
image

This PR:
image

Testing procedure

Generate the documentation and check if everything looks good.

Issues/PRs references

Details described in #21220.

@github-actions github-actions bot added the Area: doc Area: Documentation label Feb 27, 2025
@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 28, 2025
@riot-ci
Copy link

riot-ci commented Feb 28, 2025

Murdock results

✔️ PASSED

226fb87 doc/porting-boards: fix comment block style of example doc.txt

Success Failures Total Runtime
1 0 1 01m:20s

Artifacts

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reconsider this in the light of #21220 (comment)

@crasbe
Copy link
Contributor Author

crasbe commented Feb 28, 2025

Yes.

The changes to porting-boards.md would be minimal, essentially just change the headline, remove the comment blocks and possibly write a small note like this to document the changes.

Previously documentation was contained in `doc.txt` files with C-style comment
blocks. This style has been deprecated in favor of using `doc.md` files in
Markdown format, which eliminates formatting and interpretation issues.
Old style files will continually be replaced by the new format.

@kfessel do you want to add these changes to porting-boards.md in your PR #21255? Then I'll close this PR.

@mguetschow
Copy link
Contributor

@kfessel do you want to add these changes to porting-boards.md in your PR #21255? Then I'll close this PR.

I'd rather do this in a separate PR.

Otherwise I like your wording!

@crasbe crasbe closed this Feb 28, 2025
@crasbe crasbe deleted the pr/porting_boards branch March 3, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants