Skip to content

pkg/wakaama: add on off switch #21109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2025
Merged

pkg/wakaama: add on off switch #21109

merged 2 commits into from
Apr 29, 2025

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This adds a simple on/off switch object to the supported LwM2M objects: Object 3342. From the specs:

This IPSO object should be used with an On/Off switch to report the state of the switch.

switch

Testing procedure

Use the lwm2m example, the 'switch' can be controlled via shell.

Issues/PRs references

None

@github-actions github-actions bot added Area: pkg Area: External package ports Area: examples Area: Example Applications labels Dec 25, 2024
@leandrolanzieri leandrolanzieri changed the title Pkg/wakaama/add on off switch pkg/wakaama: add on off switch Dec 25, 2024
@leandrolanzieri leandrolanzieri added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Dec 25, 2024
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 25, 2024
@leandrolanzieri leandrolanzieri force-pushed the pkg/wakaama/add_on_off_switch branch from 3621c59 to 2254a35 Compare December 25, 2024 10:48
@riot-ci
Copy link

riot-ci commented Dec 25, 2024 •
edited
Loading

Murdock results

✔️ PASSED

a57d5cc examples/lwm2m: add on/off switch object

Success Failures Total Runtime
10318 0 10320 12m:01s

Artifacts

Teufelchen1
Teufelchen1 requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️ 👁️

@MrKevinWeiss MrKevinWeiss added State: waiting for end of feature-freeze Process: blocked by feature freeze Integration Process: The impact of this PR is too high for merging it during soft feature freeze. labels Jan 21, 2025
@MrKevinWeiss MrKevinWeiss removed the Process: blocked by feature freeze Integration Process: The impact of this PR is too high for merging it during soft feature freeze. label Jan 21, 2025
@MrKevinWeiss
Copy link
Contributor

Freeze is over so if anyone wants to pick this up...

mguetschow
mguetschow reviewed Jan 28, 2025
View reviewed changes
examples/lwm2m/lwm2m_cli.c Outdated
return 1;
}

bool status = !strcmp(argv[2], "on");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a tighter check for "off" than just anything except "on", I guess.

Copy link
Contributor Author

@leandrolanzieri leandrolanzieri Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the command explicitly checks for either "on" or "off".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am I blind? It does not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added here? 77bac9c

mguetschow
mguetschow reviewed Jan 29, 2025
View reviewed changes
@Teufelchen1
Copy link
Contributor

cool, almost there! I think you can fix the last open issues and directly squash them so this PR is ready for merge.
Ah and rebase + fix the conflicts.
There also minor format errors in the files, would you mind running uncrustify over it?

@leandrolanzieri leandrolanzieri force-pushed the pkg/wakaama/add_on_off_switch branch from fb2eaad to a57d5cc Compare April 29, 2025 11:41
@leandrolanzieri
Copy link
Contributor Author

cool, almost there! I think you can fix the last open issues and directly squash them so this PR is ready for merge. Ah and rebase + fix the conflicts. There also minor format errors in the files, would you mind running uncrustify over it?

done!

@Teufelchen1 Teufelchen1 added this pull request to the merge queue Apr 29, 2025
Merged via the queue into RIOT-OS:master with commit a699b7b Apr 29, 2025
26 checks passed
@leandrolanzieri
Copy link
Contributor Author

Thanks for the review!

@leandrolanzieri leandrolanzieri deleted the pkg/wakaama/add_on_off_switch branch April 30, 2025 06:08
@Teufelchen1 Teufelchen1 added this to the Release 2025.07 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow left review comments

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2025.07
Development

Successfully merging this pull request may close these issues.
6 participants
@leandrolanzieri @riot-ci @MrKevinWeiss @Teufelchen1 @mguetschow @maribu