build_system/xfa: change API to fix alignment [backport 2024.10] #21088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases the test coverage for XFA: - Multiple entries are added from a single file - Priorities are assigned to enforce a given order - The size of the `struct` to add is changed to no longer be a power of 2 (cherry picked from commit 2839224)
This changes the API of xfa from
XFA(array_name, prio) type element_name = INITIALIZER;
to
XFA(type, array_name, prio) element_name = INITIALIZER;
this allows forcing natural alignment of the type, fixing failing tests
on `native64`.
(cherry picked from commit 2b6f65a)
|
Backporting an API change would be a first I think. However, I see no other way of fixing the segfault in |
benpicco
approved these changes
Dec 15, 2024
|
It's just an internal API and if things work correctly, users shouldn't even notice the change - only when they hit the alignment bug, and this one fixes that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20960
Contribution description
This changes the API of xfa from
to
this allows forcing natural alignment of the type, fixing failing tests
on
native64.Testing procedure
The tests from #20959 is included here. It should now pass.
Issues/PRs references
Includes #20959