boards/seeedstudio-xiao-nrf52840: initial board support #20980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently failing tests: |
|
Most of those are software-only and won't depend on the board. (Thinking of it, we should probably add a general board test app that makes it easier to evaluate a newly ported board) |
This was referenced Nov 14, 2024
True, but I've still managed to find some issues which are at least board-related :)
Great, I'll have a look! Do we have a list of such useful test applications for new boards somewhere? May be good to add a pointer to the documentation.
Or even better! |
This was referenced Nov 18, 2024
4e1d250 to
f4709f9
Compare
f4709f9 to
72f9fb0
Compare
|
|
|
|
Status update on tests that have been failing previously:
Some of them fail with |
crasbe
reviewed
Dec 14, 2024
72f9fb0 to
8d59531
Compare
|
IMO it looks good and you can resolve the suggestions. I gave this a quick test run with |
45afe17 to
58c7882
Compare
For consistency with the other boards, I would probably leave them in the header. How to deal with the Do you want/need to have anything else tested specifically? It seems like the static tests are unhappy about trailing whitespaces in I ordered a Xiao nRF52840 Sense board yesterday, which we want to use for an upcoming seminar. Apparently the LSM6DS3TR-C is fully compatible with the LSM6DSL that is already implemented in RIOT :) |
benpicco
reviewed
Feb 25, 2025
As for the other boards, I've left them there and added them to the doccheck excludes (using a pattern instead of listing them all individually).
which one do you mean?
Nice, should be straightforward to add to RIOT with this one as blue-print!
I'd say I'm happy with the testing both from my and your side. Thanks again! |
Nevermind, there is no group-opening operator in the |
crasbe
reviewed
Feb 27, 2025
0ce3571 to
1c620fc
Compare
1c4831f to
8562ca9
Compare
crasbe
approved these changes
Mar 11, 2025
|
LGTM, IMO this is ready for merge. |
maribu
reviewed
Mar 11, 2025
There was a problem hiding this comment.
The CI is very unhappy about the missing space after the , in GPIO_PIN(<port>,<pin>) and cluttering the code preview with warnings to the point it is hard to read the code.
Would you mind to just obey with what the CI suggests (see inline) to get rid of the linter warnings?
8562ca9 to
a0678a7
Compare
Sure sorry, done :) |
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Initial board support for the tiny Seed Studio XIAO nRF52840. It uses the same bootloader as the Adafruit nrf52840 Feather (Sense) boards.
Testing procedure
I'm still in the process of running
BUILD_IN_DOCKER=1 dist/tools/compile_and_test_for_board/compile_and_test_for_board.py . seeedstudio-xiao-nrf52840locally and will report back with the result later.Look through the header and configuration files. I've mostly followed the example from
feather-nrf52840-senseandnrf52840dk(for the external flash).Check generated documentation for the board.