Skip to content

boards/nucleo-l452re: add ADC #20778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2024
Merged

boards/nucleo-l452re: add ADC #20778

merged 2 commits into from
Jul 8, 2024

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

This PR adds to the Nucleo-l452re ADC configuration.

Testing procedure

Flash the board using tests/periph_adc program. Check if measured values changes when A0-A5 pins are
connected to the 3,3V, GND or to the potentiometer.

Solution was successfully tested by @crasbe - more details PR #20756.

Issues/PRs references

PR #20756

@krzysztof-cabaj krzysztof-cabaj requested a review from aabadie as a code owner July 5, 2024 16:41
@github-actions github-actions bot added the Area: boards Area: Board ports label Jul 5, 2024
@crasbe
Copy link
Contributor

crasbe commented Jul 5, 2024

I think you have to rebase the PR, it does not include your previous fix yet. (Doesn't matter for the merge though, just makes testing more complicated.)

chris@ThinkPias:~/RIOTdev/RIOT$ git log --oneline -n 5
85e028ad99 (HEAD -> nucleo-l452re-ADC) boards/nucleo-l452re: add doxygen doc to ADC
ff617310e6 boards/nucleo-l452re: add ADC support
436b6edb69 Merge pull request #20767 from krzysztof-cabaj/stm32l0538-disco-DOC
0d4d8d6a15 Merge pull request #20768 from mguetschow/tests-progressbar-fixed
86b0c5bc9a tests/sys/progress_bar: remove debug print

I rebased it locally and can confirm it is still working as it should :)

crasbe
crasbe reviewed Jul 5, 2024
View reviewed changes
@krzysztof-cabaj
Copy link
Contributor Author

@crasbe thanks for valuable comments.

I rebase the code. I actually mismatch nucleo board manual and MCU datasheet - in current version I placed both of these information.

@crasbe
Copy link
Contributor

crasbe commented Jul 6, 2024

@krzysztof-cabaj Thank you for doing this PR even though you don't have an L452RE Nucleo :)

@dylad dylad added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 8, 2024
@riot-ci
Copy link

riot-ci commented Jul 8, 2024

Murdock results

✔️ PASSED

02ecded boards/nucleo-l452re: add doxygen doc to ADC

Success Failures Total Runtime
558 0 558 04m:49s

Artifacts

dylad
dylad approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@dylad dylad enabled auto-merge July 8, 2024 08:17
@dylad dylad added this pull request to the merge queue Jul 8, 2024
Merged via the queue into RIOT-OS:master with commit 55a35c5 Jul 8, 2024
3 checks passed
@krzysztof-cabaj
Copy link
Contributor Author

@crasbe, @dylad thanks for support!

@mguetschow mguetschow added this to the Release 2024.07 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crasbe crasbe crasbe left review comments

@dylad dylad dylad approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krzysztof-cabaj @crasbe @riot-ci @dylad @mguetschow