Skip to content

Conversation

maribu
Copy link
Member

@maribu maribu commented Jun 4, 2024

Contribution description

This fixes a typo in computation in thread_measure_stack_free, which messed up the computation.

Testing procedure

Output of ps should look sane again.

Issues/PRs references

Regression of

This fixes a typo in computation in thread_measure_stack_free, which
messed up the computation.
@maribu maribu requested a review from kaspar030 as a code owner June 4, 2024 15:01
@github-actions github-actions bot added the Area: core Area: RIOT kernel. Handle PRs marked with this with care! label Jun 4, 2024
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 4, 2024
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jun 4, 2024
benpicco
benpicco previously approved these changes Jun 4, 2024
@benpicco benpicco requested a review from miri64 June 4, 2024 15:20
@benpicco benpicco enabled auto-merge June 4, 2024 15:24
@miri64 miri64 dismissed benpicco’s stale review June 4, 2024 15:46

Let's not do the same mistake again, even if you just contributed the test.

@miri64 miri64 added the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Jun 4, 2024
@github-actions github-actions bot added the Process: missing approvals Integration Process: PR needs more ACKS (handled by action) label Jun 4, 2024
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, confirmed that this fixed the ps output both on native and nrf52840dongle

@miri64 miri64 requested a review from chrysn June 4, 2024 15:49
@maribu maribu disabled auto-merge June 4, 2024 16:25
@maribu maribu closed this Jun 4, 2024
@maribu maribu deleted the core/thread/measure_stack branch June 4, 2024 16:25
@maribu
Copy link
Member Author

maribu commented Jun 4, 2024

Closed in favor of #20723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: missing approvals Integration Process: PR needs more ACKS (handled by action) Process: needs >1 ACK Integration Process: This PR requires more than one ACK Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants