pkg/wamr: updated package to WAMR 1.3.3 #20691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
reviewed
May 23, 2024
| @@ -1,10 +1,10 @@ | |||
| PKG_NAME=wamr | |||
| PKG_URL=https://github.com/bytecodealliance/wasm-micro-runtime.git | |||
| ifeq ($(PKG_BLEADING),1) | |||
| ifeq ($(PKG_BLEEDING),1) | |||
| PKG_VERSION=main | |||
There was a problem hiding this comment.
If this doesn't work, you can just drop it.
There was a problem hiding this comment.
does work for me ( just tested)
$ cd <RIOT>/examples/wasm
$ PKG_BLEADING=1 make
$ cd <RIOT>/build/pkg/wamr
$ git status
On branch main
Your branch is up to date with 'origin/main'.
$ cd <RIOT>/examples/wasm
$ make
$ cd <RIOT>/build/pkg/wamr
$ git status
HEAD detached at dc4dcc3
There was a problem hiding this comment.
Thank you for catching the typo
Sadly this currently the only package to support a instantaneous test with the current upstream main branch.
The PKG_VERSION= supports hashes, tags, and branches main is a branch.
We usually only use hashes because everything else can change, and we might have to do much work to keep track especially if projects change API, or we apply patches. At least the patches are very avoidable with wamr, since the upstream is very responsive.
kfessel
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR updates WAMR to its 1.3.3 version referenced by this commit hash : 3f5e2bd23bcb8eb3767c8e17789c6a2e3e912a08.
I'd like some opinions about whether the
PKG_BLEEDINGcondition (and variable) should be kept because this variable is not used somewhere else. Also themaintag does not exist and anyway tag names are not supported there, only commits hashes are.Testing procedure
Use various boards to see if the example/wamr still work.
I tested it with this example and another homemade one and the behavior was the same as the old version. The tests were made using an arduino nano 33 ble (and sense) and a dwm1001.
Please note that the text+data values are slightly larger but the bss (ram) new use is not significant from what I saw.
Issues/PRs references
N/A