Skip to content

Conversation

maribu
Copy link
Member

@maribu maribu commented May 22, 2024

Contribution description

The board white list was needed as temporary workaround during the KConfig migration. As the migration was aborted, the workaround should no longer be needed.

Testing procedure

This enables a few additional builds on the CI. Hence, the CI should do all the testing.

Issues/PRs references

Partially fixes #20680

@maribu maribu added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 22, 2024
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label May 22, 2024
@benpicco benpicco requested a review from MrKevinWeiss May 22, 2024 15:54
@riot-ci
Copy link

riot-ci commented May 22, 2024

Murdock results

✔️ PASSED

cbcf568 tests: drop temporary KConfig workaround

Success Failures Total Runtime
54 0 54 01m:36s

Artifacts

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MrKevinWeiss MrKevinWeiss enabled auto-merge May 23, 2024 14:18
@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue May 23, 2024
@MrKevinWeiss
Copy link
Contributor

Let's see if the checks pass

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
The board white list was needed as temporary workaround during the
KConfig migration. As the migration was aborted, the workaround should
no longer be needed.

Partially fixes RIOT-OS#20680
@maribu maribu force-pushed the tests/drop-kconfig-workaround branch from 8599c11 to cbcf568 Compare May 24, 2024 16:07
@maribu maribu enabled auto-merge May 24, 2024 17:01
@maribu
Copy link
Member Author

maribu commented May 24, 2024

Let's see if just updating the Makefile.cis for boards previously not in the whitelist did the trick.

@maribu maribu added this pull request to the merge queue May 24, 2024
Merged via the queue into RIOT-OS:master with commit 4131abd May 24, 2024
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test files required to compile
4 participants