tests: Add cases to the scn_u32_hex unittest #20463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfessel
approved these changes
Mar 12, 2024
17cb3ce to
fca1c4e
Compare
|
you might want to add a test that test if the |
fca1c4e to
79a77db
Compare
|
I assumed Line 868 would cover that? I added a more explicit test tho. |
kfessel
approved these changes
Mar 12, 2024
|
Thanks for dealing with this quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Follow-up to #20458
@kfessel discovered that the tests were still insufficient. This adds the missing cases.
Technically, all ascii characters could be tested separately...
Testing procedure
make -C tests/unittests/ tests-fmt termIssues/PRs references
#19894