Skip to content

Conversation

crasbe
Copy link
Contributor

@crasbe crasbe commented Feb 29, 2024

Contribution description

The doc.txt file of the uwb-dw1000 package included to the incorrect README.md file (from pkg/ucglib) instead of pkg/uwb-dw1000, which led to the generation of incorrect Doxygen documentation.

Testing procedure

With the change applied, the Doxygen documentation should still successfully build and now have the correct description of the UWB-DW1000 package.

Issues/PRs references

No separate issue opened.

@github-actions github-actions bot added Area: doc Area: Documentation Area: pkg Area: External package ports labels Feb 29, 2024
@crasbe crasbe changed the title Fix the documentation for uwb-dw1000 package pkg/uwb-dw1000: fix README include Feb 29, 2024
@benpicco
Copy link
Contributor

Please also amend your commit title like you did with the PR title

@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Feb 29, 2024
The doc.txt file referred to the incorrect README.md file (from pkg/ucglib) instead of pkg/uwb-dw1000, which led to the generation of incorrect Doxygen documentation.
@crasbe
Copy link
Contributor Author

crasbe commented Feb 29, 2024

I changed the commit title. Sorry for the oversight, this is new (git) territory for me.

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem 🙂

@benpicco benpicco enabled auto-merge February 29, 2024 17:02
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 29, 2024
@riot-ci
Copy link

riot-ci commented Feb 29, 2024

Murdock results

✔️ PASSED

92f73e7 pkg/uwb-dw1000: fix README include

Success Failures Total Runtime
1 0 1 12s

Artifacts

@benpicco benpicco added this pull request to the merge queue Feb 29, 2024
Merged via the queue into RIOT-OS:master with commit 676bfa1 Feb 29, 2024
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
@crasbe crasbe deleted the patch-2 branch May 6, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants