Skip to content

tests: Slightly increase coverage of fmt unittests #20272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

tests: Slightly increase coverage of fmt unittests #20272

merged 1 commit into from
Jan 23, 2024

Conversation

Teufelchen1
Copy link
Contributor

Contribution description

Hello 🐑

Slightly increases the coverage of the unit tests. Despite shuffling the order of tests, no coverage is lost.
This also reorders the API definitions in fmt.h - I'm sorry I just couldn't resist.

Testing procedure

make -C tests/unittests/ tests-fmt test or just wait for the CI

Issues/PRs references

Follow-up to #20198

@Teufelchen1 Teufelchen1 requested a review from miri64 as a code owner January 18, 2024 13:11
@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: sys Area: System labels Jan 18, 2024
MrKevinWeiss
MrKevinWeiss approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck ya, (many) small improvements are the best! Thanks, aside from small comments I would say ACK. You can squash directly.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 18, 2024
@riot-ci
Copy link

riot-ci commented Jan 18, 2024 •
edited
Loading

Murdock results

✔️ PASSED

7c39b48 tests: Slightly increase coverage of fmt unittests

Success Failures Total Runtime
8629 0 8629 12m:07s

Artifacts

mguetschow
mguetschow reviewed Jan 18, 2024
View reviewed changes
mguetschow
mguetschow requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way cleaner now indeed! Just one comment remaining.

mguetschow
mguetschow approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR wasn't fun 🤡

I do think it was, at least I've learned something along the way 😉

I think its ready for merge - do you give your blessing?

Amen 🙏 Thanks for slowly but steadily improving the RIOT tests!

@mguetschow mguetschow enabled auto-merge January 23, 2024 09:39
@mguetschow mguetschow added this pull request to the merge queue Jan 23, 2024
Merged via the queue into RIOT-OS:master with commit 50cf7b7 Jan 23, 2024
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@mguetschow mguetschow mguetschow approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

Assignees
No one assigned
Labels
Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
5 participants
@Teufelchen1 @riot-ci @MrKevinWeiss @mguetschow @benpicco