Skip to content

pkg/driver_sx126x: update to v2.3.2 #20255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pkg/driver_sx126x: update to v2.3.2 #20255

wants to merge 1 commit into from

Conversation

donsez
Copy link
Contributor

@donsez donsez commented Jan 14, 2024

Contribution description

The PR is the update of pkg/sx126x_driver repository for the tag 2.3.2 of the source repository.

NB: the tag 2.3.2 includes the implementation of LR-FHSS driver for Semtech SX126x transceivers.

Testing procedure

The update has been tested with a lora-e5-dev board with tests/pkg/semtech-loramac and a Chirpstack LNS (LoRaWAN network server) private instance.

make BOARD=lora-e5-dev LORA_DRIVER=sx126x_stm32wl
> main(): This is RIOT! (Version: 2022.01-devel-8326-gf7d01-pr/upgrade_driver_sx126x)
All up, running the shell now
> loramac set dr 5
> loramac set deveui 0a5acb4b41b95e51
> loramac set appkey 4B20EF23B1C3A9393F034F6527CA71F0
> loramac set adr on
> loramac join otaa
Join procedure succeeded!
> loramac get devaddr
DEVADDR: FC00AF6C
> loramac get appskey
APPSKEY: 5FECF818F9D72C7A5C3D56455C388508
> loramac get nwkskey
NWKSKEY: B770CCDD304045331EECA034821A0C7C
> loramac tx HELLO cnf 10
Received ACK from network
Message sent with success
> loramac get ul_cnt
Uplink Counter: 1
> loramac link_check
Link check request scheduled
> loramac tx BONJOUR uncnf 11
Link check information:
  - Demodulation margin: 10
  - Number of gateways: 1
Data received: HELLO_WORLD, port: 20
Message sent with success
> loramac get ul_cnt
Uplink Counter: 2

Issues/PRs references

@github-actions github-actions bot added the Area: pkg Area: External package ports label Jan 14, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 15, 2024
@benpicco benpicco requested review from aabadie and jia200x January 15, 2024 12:15
@riot-ci
Copy link

riot-ci commented Jan 15, 2024

Murdock results

✔️ PASSED

92a6e41 update for sx126x_driver v2.3.2

Success Failures Total Runtime
8101 0 8101 11m:50s

Artifacts

@benpicco benpicco changed the title update for sx126x_driver v2.3.2 pkg/driver_sx126x: update to v2.3.2 Jan 17, 2024
@benpicco
Copy link
Contributor

Thank you for the patch, CI is complaining about the commit message: Can you please prefix it with the package involved (just like the PR title) with git commit --amend

@benpicco
Copy link
Contributor

@donsez ping

@crasbe
Copy link
Contributor

crasbe commented Apr 27, 2025

@donsez ping :)

@benpicco benpicco requested a review from fabian18 April 28, 2025 07:02
@fabian18
Copy link
Contributor

The header sx126x_lr_fhss.h in the package still includes an "sx126x.h".
I think the patch renames the package sx126x.h to sx126x_driver.h to not clash with our drivers/include/sx126x.h.

One nice addition now is to have sx126x_driver_version.h.
How about including this in sx126x_driver.h, so that out code could query the version.
If our code includes sx126x_driver_version.h, it will fail because it does not exist for 1.0.0.
So by placing it in the major driver header it would just sneak in and I could use something like

#ifdef SX126X_DRIVER_VERSION_CHECK

and check for a version.

Maybe this should be suggested to the sx126 repo.

@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for author State: Action by the author of the PR is required labels May 29, 2025
@benpicco benpicco mentioned this pull request Jun 2, 2025
Merged
@benpicco
Copy link
Contributor

benpicco commented Jun 2, 2025

See #21521 for an alternative approach - we don't need to patch the vendor files at all.

@crasbe
Copy link
Contributor

crasbe commented Jun 3, 2025

Closed in favor of the alternative approach.

@crasbe crasbe closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie

@jia200x jia200x Awaiting requested review from jia200x

@fabian18 fabian18 Awaiting requested review from fabian18

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for author State: Action by the author of the PR is required Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@donsez @riot-ci @benpicco @crasbe @fabian18