Skip to content

tests/test-rtc: test retrieval of unix-time #20031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

tests/test-rtc: test retrieval of unix-time #20031

merged 1 commit into from
Jan 24, 2025

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented Oct 30, 2023

Contribution description

adds a test for unixtime conversion to our rtc function tests.

Testing procedure

make -C tests/unittests/tests-rtc/ tests-rtc test

Issues/PRs references

#20023

@kfessel kfessel requested a review from miri64 as a code owner October 30, 2023 16:59
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Oct 30, 2023
@kfessel kfessel changed the title tests/test-rtc: test retrivel of unix-time tests/test-rtc: test retrieval of unix-time Oct 30, 2023
@kfessel kfessel mentioned this pull request Oct 30, 2023
Merged
@kfessel kfessel requested a review from maribu October 30, 2023 17:52
Teufelchen1
Teufelchen1 reviewed Nov 2, 2023
View reviewed changes
@kfessel kfessel added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 2, 2023
@riot-ci
Copy link

riot-ci commented Nov 2, 2023 •
edited
Loading

Murdock results

✔️ PASSED

254d133 tests/test-rtc: test retrieval of unix-time

Success Failures Total Runtime
17 0 17 01m:46s

Artifacts

@kfessel kfessel requested a review from bergzand November 3, 2023 09:10
@kfessel kfessel force-pushed the p-test-unix-time branch 3 times, most recently from 647297e to 49c219c Compare November 3, 2023 14:00
@kfessel
Copy link
Contributor Author

kfessel commented Nov 3, 2023

added some comment informing the reader why the test might have failed

@kfessel
Copy link
Contributor Author

kfessel commented Nov 20, 2023

thank you

@mguetschow
Copy link
Contributor

@Teufelchen1 mind to take another look at this?

Teufelchen1
Teufelchen1 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks still good to me

@mguetschow mguetschow added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 4, 2024
@Teufelchen1 Teufelchen1 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 12, 2024
@mguetschow mguetschow added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 26, 2024
@mguetschow mguetschow marked this pull request as draft November 26, 2024 09:46
@mguetschow mguetschow marked this pull request as ready for review November 26, 2024 09:47
@mguetschow
Copy link
Contributor

@kfessel Would you mind rebasing on current master to try to get the CI unstuck?

@mguetschow mguetschow added this pull request to the merge queue Jan 24, 2025
Merged via the queue into RIOT-OS:master with commit 71437f2 Jan 24, 2025
25 checks passed
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2025.04
Development

Successfully merging this pull request may close these issues.
5 participants
@kfessel @riot-ci @mguetschow @maribu @Teufelchen1