netdev: unify msg type macro with msg type macros in netapi #2427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d043d4 to
1aa3d16
Compare
1aa3d16 to
451f1e4
Compare
451f1e4 to
7fec83c
Compare
|
Rebased to #2428 |
| @@ -121,8 +121,8 @@ typedef struct { | |||
| * @return -EOVERFLOW if available space in *value* given in | |||
| * *value_len* is too small to store the option value | |||
| */ | |||
| int (*get)(ng_netdev_t *dev, ng_netconf_opt_t opt, | |||
| void *value, size_t *value_len); | |||
There was a problem hiding this comment.
acutally I purposely put value and value_len in the same row, as they kind of belong together...
|
#2428 is merged. You could consider my comment on the line break changes, but anyhow: ACK when rebased. |
|
also adjusted #2426 to cope with this PR |
01a8d9e to
15a6e20
Compare
|
Considered comment and waiting for Travis… don't understand why I need to rebase. |
Me neither. |
|
Kicked Travis… for the third time… |
miri64
added a commit
that referenced
this pull request
Feb 12, 2015
netdev: unify msg type macro with msg type macros in netapi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.