lwip_sock: provide implementation for sock_*_recv_buf()
#13701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
commented
Mar 24, 2020
This was referenced Mar 28, 2020
54aefea to
1870f3e
Compare
|
If this can be reviewed now, just squash - there hasn't been a review yet. |
|
I'm not really familiar with lwip but I compared this PR with how sock_udp_recv_buf is implemented and used in gnrc and overall it looks good to me. For testing, I ran the command described in the testing procedure above and all tests completed successfully. I'm not sure how to tests using fragmented packets. Do you have an extra application written for that @miri64? Sorry, I cannot add much to the review but I can help tests it locally to confirm that it is working. |
78f11e0 to
53b5f37
Compare
Squashed |
No, not really. However, |
|
Can this be tested entirely on |
Yepp, the automated version of |
I reckon |
No.
As I wrote: use |
|
I adapted diff --git a/tests/lwip/common.h b/tests/lwip/common.h
index 4cea2573df..6d0778a6f6 100644
--- a/tests/lwip/common.h
+++ b/tests/lwip/common.h
@@ -29,7 +29,7 @@ extern "C" {
* @brief Application configuration
* @{
*/
-#define SOCK_INBUF_SIZE (256)
+#define SOCK_INBUF_SIZE (1500)
#define SERVER_MSG_QUEUE_SIZE (8)
#define SERVER_BUFFER_SIZE (64)
/**Then I started 3 terminals: Terminal 1 (
|
MichelRottleuthner
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This provides an implementation for lwIP of the zero-copy receive functions (see #13616). As the implementation of sock_*_recv() now uses those functions, I only adapted the tests minimally to test the success case to acknowledge the function is there.
I am not 100% sure it is okay, not to loop over the netbuf in
sock_udp(forsock_ipI did not), but testing will tell.Testing procedure
Should still pass (only
LWIP_IPV6=1is tested by the CI):Also please, please, please test with (IP) fragmented packets (so larger than MTU) for
sock_udpwithtests/lwip. I did not have any time to test that right now, but we really should, as I removed a copying loop and replaced it just with a pointer assignment (see #13701 (comment) for procedure).Issues/PRs references
Follow-up to #13616.
Requires
#13779(merged).