Skip to content

drivers/ili9341: use const qualifier where possible #13261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

drivers/ili9341: use const qualifier where possible #13261

merged 1 commit into from
Feb 4, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 2, 2020

Contribution description

This PR adds the const qualifier for the dev param in the ili9341 driver. With this PR, the driver is more compliant with RIOT drivers implementation guidelines.
Especially the line: MUST: use const devab_t *dev when the device descriptor can be access read-only

Testing procedure

  • Verify that tests/driver_ili9341 works (tested with success on stm32f429i-disc1).
  • A green Murdock

Issues/PRs references

None

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 2, 2020
@aabadie aabadie requested a review from bergzand February 2, 2020 18:00
@bergzand bergzand added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Feb 2, 2020
@aabadie aabadie mentioned this pull request Feb 2, 2020
Merged
@aabadie
Copy link
Contributor Author

aabadie commented Feb 4, 2020

ok to merge @bergzand ?

@bergzand
Copy link
Member

bergzand commented Feb 4, 2020

Verify that tests/driver_ili9341 works (tested with success on stm32f429i-disc1).

I haven't tested this, but I'm sure you can show it to me quickly in a second or so, then I'm ok to merge this :)

bergzand
bergzand approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@bergzand bergzand merged commit 8e85c2d into RIOT-OS:master Feb 4, 2020
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Feb 20, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 20, 2020
@aabadie aabadie deleted the pr/drivers/ili9341_const branch March 5, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @bergzand @leandrolanzieri