Skip to content

Conversation

wosym
Copy link
Member

@wosym wosym commented Dec 6, 2019

Contribution description

Add glue code to initialize Ethernet and add netif for stm32 in lwip_bootstrap.
LWIP now supports STM32.

Testing procedure

Before:
tests/lwip --> send_ip() --> fails, because there is no available netif
After:
tests/lwip --> send_ip() --> works

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward, just two minor coding style nits.

@miri64 miri64 added Area: network Area: Networking Area: pkg Area: External package ports Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Dec 6, 2019
Fix minor coding style issues
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 6, 2019
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small addition, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants