gnrc_tcp: allow unknown options #12298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
requested changes
Sep 24, 2019
632a0c5 to
dee092e
Compare
dee092e to
fdda22c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest hardening of the gnrc_tcp option parser was a bit too restrictive.
Packets with unknown options were dropped by gnrc_tcp. This leads to problems then communicating with feature complete tcp implementations, since valid options like SACK are often announced in first SYN Packet. Without this PR such a SYN would be dropped by gnrc_tcp.
This PR allows packets with unknown options to be valid as long as they respect the boundaries of the option field and the option minimal length.