Skip to content

gnrc_tcp: abort on unknown option #12245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

gnrc_tcp: abort on unknown option #12245

merged 1 commit into from
Sep 16, 2019

Conversation

nmeum
Copy link
Member

@nmeum nmeum commented Sep 16, 2019

Fixes #12086

@miri64 miri64 added Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 16, 2019
miri64
miri64 approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Tested the steps to reproduce in #12086 and also normal operations of gnrc_tcp_server/gnrc_tcp_client

@miri64 miri64 merged commit 1dcf88e into RIOT-OS:master Sep 16, 2019
@nmeum
Copy link
Member Author

nmeum commented Sep 16, 2019

Forgot to mention that I didn't read the RFC and just wanted to fix the issue. No idea what behaviour the RFC mandates.

@miri64
Copy link
Member

miri64 commented Sep 16, 2019

Forgot to mention that I didn't read the RFC and just wanted to fix the issue. No idea what behaviour the RFC mandates.

Me neither, but only thing that could be wrong, that the option should be ignored. If that is the case we can fix that later. It's more important to close a potential attack vector first.

@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 17, 2019
@nmeum nmeum mentioned this pull request Jan 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.

gnrc_tcp: option parsing doesn't terminate on all inputs, potential DOS
3 participants
@nmeum @miri64 @kb2ma