Skip to content

cpu/nrf5x_common: add flashpage_raw_support #11956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2019
Merged

cpu/nrf5x_common: add flashpage_raw_support #11956

merged 1 commit into from
Aug 7, 2019

Conversation

fjmolinas
Copy link
Contributor

Contribution description

This PR adds flashpage_raw support for nrf5x.

Testing procedure

Run: make -C tests/periph_flashpage/ BOARD=nrf52840dk flash test

Tested locally on nrf52840dk, nrf52840-mdk and over iotlab on microbit and nrf51dk.

Issues/PRs references

@fjmolinas fjmolinas added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Area: OTA Area: Over-the-air updates labels Aug 5, 2019
@fjmolinas fjmolinas requested a review from aabadie August 5, 2019 09:43
aabadie
aabadie reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Tested on iotlab on nrf52dk, nrf52840dk, nrf51dk and microbit and locally on nrf52840-mdk. All tests passed with success.

@fjmolinas fjmolinas force-pushed the pr_nrf5x_flashpage_raw branch from b03ed93 to 254934d Compare August 5, 2019 15:46
@aabadie
Copy link
Contributor

aabadie commented Aug 5, 2019

Murdock is failing on nrf52dk but this seems unrelated:

Downloading file [/tmp/dwq.0.10813082557054066/8d18100dc3f8f2f6483140d59d07280e/tests/nordic_softdevice/bin/nrf52dk/softdevice.hex]...
Failed to open file.

Script processing completed.

/tmp/dwq.0.10813082557054066/8d18100dc3f8f2f6483140d59d07280e/tests/nordic_softdevice/../../Makefile.include:550: recipe for target 'flash-only' failed
make: *** [flash-only] Error 1
make: Leaving directory '/tmp/dwq.0.10813082557054066/8d18100dc3f8f2f6483140d59d07280e/tests/nordic_softdevice'
make: Entering directory '/tmp/dwq.0.10813082557054066/8d18100dc3f8f2f6483140d59d07280e/tests/nordic_softdevice'
/bin/sh: 1: arm-none-eabi-gcc: not found
Timeout in expect script at "child.expect("All up, running the shell now")" (tests/nordic_softdevice/tests/01-run.py:8)

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 6, 2019
@fjmolinas fjmolinas added CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Aug 7, 2019
@fjmolinas
Copy link
Contributor Author

@aabadie I re-triggered the build and it succeeded.

aabadie
aabadie approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK and go!

@aabadie aabadie merged commit a6685b0 into RIOT-OS:master Aug 7, 2019
@fjmolinas fjmolinas deleted the pr_nrf5x_flashpage_raw branch August 7, 2019 15:40
@fjmolinas fjmolinas mentioned this pull request Aug 8, 2019
Merged
@fjmolinas
Copy link
Contributor Author

@aabadie Thanks for the review!

@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: OTA Area: Over-the-air updates CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@fjmolinas @aabadie @kb2ma