Skip to content

dist/tools/build_system_sanity_check: deprecate FEATURES_MCU_GROUP #11671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

dist/tools/build_system_sanity_check: deprecate FEATURES_MCU_GROUP #11671

wants to merge 2 commits into from

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 11, 2019 •
edited
Loading

Contribution description

Add a function to list deprecated variables or patterns and use it for

  • FEATURES_MCU_GROUP

The pull request also adds a reasons for each error type found by the script that I will split.

Testing procedure

Run the current version without rebasing

./dist/tools/buildsystem_sanity_check/check.sh  | head
Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:

Deprecated variables or patterns:
boards/arduino-zero/Makefile.features:FEATURES_MCU_GROUP = cortex_m0_2
boards/avsextrem/Makefile.features:FEATURES_MCU_GROUP = arm7
boards/b-l072z-lrwan1/Makefile.features:FEATURES_MCU_GROUP = cortex_m0_1
boards/b-l475e-iot01a/Makefile.features:FEATURES_MCU_GROUP = cortex_m4_2
boards/cc2538dk/Makefile.features:FEATURES_MCU_GROUP = cortex_m3_1
boards/cc2650-launchpad/Makefile.features:FEATURES_MCU_GROUP = cortex_m3_1
boards/cc2650stk/Makefile.features:FEATURES_MCU_GROUP = cortex_m3_1
boards/chronos/Makefile.features:FEATURES_MCU_GROUP = msp430

Rebase it on top of #11670 and it should output no errors

Issues/PRs references

@cladmi cladmi added Area: tests Area: tests and testing framework Area: build system Area: Build system State: waiting for other PR State: The PR requires another PR to be merged first labels Jun 11, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 11, 2019
This was referenced Jun 11, 2019
Merged
Merged
@cladmi cladmi force-pushed the pr/buildsystem_sanity_check/add_reasons_in_output branch from 3b48bb8 to da5e161 Compare June 11, 2019 10:25
@cladmi
Copy link
Contributor Author

cladmi commented Jun 11, 2019

Rebased on #11672 and added fixup for newline.

cladmi added 2 commits June 14, 2019 10:58
@cladmi
dist/tools/build_system_sanity_check: BUG fix errors being ignored
b744ba7 
On error messages the exit code was still 0 due to the typo.
Having error messages again properly return with an exit code of 1.
@cladmi
dist/tools/build_system_sanity_check: deprecate FEATURES_MCU_GROUP
aadd246 
Add a function to list deprecated variables or patterns and use it for
* FEATURES_MCU_GROUP
@cladmi cladmi force-pushed the pr/buildsystem_sanity_check/add_reasons_in_output branch from 9c4520f to aadd246 Compare June 14, 2019 09:21
@cladmi
Copy link
Contributor Author

cladmi commented Jun 17, 2019

Closed by being integrated in #11670

@cladmi cladmi closed this Jun 17, 2019
@cladmi cladmi deleted the pr/buildsystem_sanity_check/add_reasons_in_output branch June 17, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: build system Area: Build system Area: tests Area: tests and testing framework State: waiting for other PR State: The PR requires another PR to be merged first
Projects
None yet
Milestone
Release 2019.07
Development

Successfully merging this pull request may close these issues.
1 participant
@cladmi