Skip to content

usbdev: fix usbopt argument for getter/setter wrappers #11633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

usbdev: fix usbopt argument for getter/setter wrappers #11633

merged 1 commit into from
Jun 5, 2019

Conversation

bergzand
Copy link
Member

@bergzand bergzand commented Jun 5, 2019

Contribution description

bug found by llvm while testing #10916

Testing procedure

the build at #10916 (which is now based on this PR) should succeed also for llvm.

Issues/PRs references

required for #10916

@bergzand bergzand added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: USB Area: Universal Serial Bus labels Jun 5, 2019
@bergzand bergzand mentioned this pull request Jun 5, 2019
Merged
1 task
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 5, 2019
miri64
miri64 approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but from looking at the types and driver functions (and the errors in #10916) it is clear, that this should have been usbopt_t.

@miri64 miri64 merged commit b4fbfd7 into RIOT-OS:master Jun 5, 2019
@bergzand
Copy link
Member Author

bergzand commented Jun 5, 2019

Thanks!

@bergzand bergzand deleted the pr/usb/fix_usbdev_wrapper branch June 5, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

@dylad dylad

Labels
Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergzand @miri64 @dylad