Skip to content

gnrc_sixlowpan: clean-up configuration and expose via config group #11415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2019
Merged

gnrc_sixlowpan: clean-up configuration and expose via config group #11415

merged 4 commits into from
Apr 18, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 17, 2019

Contribution description

Bringing GNRC's 6LoWPAN module towards #10566 (also I need the last part for my current experiments ;-)). This PR

  • removes the net/gnrc/sixlowpan/nd/border_router.h header, since the only define in it is nowhere used,
  • moves all remaining configurable macros from net/gnrc/sixlowpan* to net/gnrc/sixlowpan/config.h, and
  • exposes RBUF_SIZE and RBUF_TIMEOUT for compile time configuration via the new macros GNRC_SIXLOWPAN_FRAG_RBUF_SIZE and GNRC_SIXLOWPAN_FRAG_RBUF_TIMEOUT_MS respectively.

Testing procedure

Read and compile (the latter should still work, I don't know about the first ;-)).

Issues/PRs references

Addresses #10566

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force labels Apr 17, 2019
@miri64 miri64 requested review from cladmi and jia200x April 17, 2019 19:48
@miri64 miri64 mentioned this pull request Apr 17, 2019
Open
@jia200x
Copy link
Member

jia200x commented Apr 18, 2019

thanks for tackling this!

Murdock complains because of undocumented defines

@miri64 miri64 force-pushed the gnrc_sixlowpan/enh/expose-config branch from c3a004e to 9192287 Compare April 18, 2019 10:22
@miri64
Copy link
Member Author

miri64 commented Apr 18, 2019

Piggy-backed documentation on those two functions, Murdock and Travis were complaining about.

@miri64
Copy link
Member Author

miri64 commented Apr 18, 2019

Got permission to squash offline

@miri64 miri64 force-pushed the gnrc_sixlowpan/enh/expose-config branch from 413e59b to 6610ac9 Compare April 18, 2019 10:32
@miri64
Copy link
Member Author

miri64 commented Apr 18, 2019

Fixed Murdock complained

miri64 and others added 2 commits April 18, 2019 14:19
@miri64
gnrc_sixlowpan_frag: expose reassembly buffer configuration
1550390 
Both values are not standardized so there is no sense keeping these
values not configurable
@miri64
gnrc_sixlowpan_frag/rbuf: document undocumented functions
43dedfc 
This adds documentation for the following undocumented functions:

- rbuf_rm()
- rbuf_entry_empty()
@miri64 miri64 force-pushed the gnrc_sixlowpan/enh/expose-config branch from 39a0637 to 43dedfc Compare April 18, 2019 12:20
@miri64
Copy link
Member Author

miri64 commented Apr 18, 2019

And squashed again.

jia200x
jia200x approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK now. ACK

@miri64 miri64 merged commit ca267fc into RIOT-OS:master Apr 18, 2019
@miri64 miri64 deleted the gnrc_sixlowpan/enh/expose-config branch April 18, 2019 14:01
@miri64
Copy link
Member Author

miri64 commented Apr 18, 2019

Thanks for the review!

This was referenced Apr 18, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@cladmi cladmi Awaiting requested review from cladmi

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR TF: Config Marks issues and PRs related to the work of the Configuration Task Force Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @jia200x