-
Notifications
You must be signed in to change notification settings - Fork 2.1k
boards: add support for Phytec 'reel board' #11096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
forgot to remove the pwm feature for the board (as I did not define any configuration for this). Now Murdock should hopefully be happy... |
What version of OpenOCD are you using? I'm getting the following error:
Also, if someone else wants to try this, be sure to move the switch out of the "off" position, seems like they cheaped out and didn't include a power multiplexer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor comments, even if it looks good in general code-wise. I haven't the board for testing but you can easily find someone in Berlin for this.
boards/reel/doc.txt
Outdated
|
||
## Overview | ||
|
||
The 'reel board' is an IoT development platform base on Nordic's nRF52840 SoC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/base on/based on/
boards/reel/doc.txt
Outdated
@@ -0,0 +1,14 @@ | |||
/** | |||
@defgroup boards_reel reel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The board group name should be more explicit, e.g. something like Phytec reel board
or something. Otherwise, this will just add an entry called 'reel' in the doxygen documentation, this will look weird.
Regarding the build system, I know 'reel' is fast and simple to type when calling make, but it's also a too generic word. What about using phytec-reel
? Like this it will be listed close to other phytec boards (pba-xxx-zz-kw2x and phynode-kw41z).
This second comment is not blocking, and after all, you are the author, so you decide ;)
all comments addressed. |
Anyone care to ACK so I can squash? |
After upgrading to OpenOCD 0.10.0+dev-00706-g4db695c66 (from the AUR) I was able to flash. I ran Failures during test:
All these failures originate in the #include <unistd.h>
int main(void)
{
write(1, "123456789\n", 10);
return 0;
} |
I don't have the Will give this another try tomorrow when I'm back in the office. |
Just tested on the Will debug this today to see whats causing this... |
As suspected, the issue at hand was unrelated to this PR (effecting all So this PR should be ready to go then? |
I'm out of office until Tuesday. Squash, there is no point in keeping it unsquashed. |
00c23b7
to
ada1d3c
Compare
squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passing, except gnrc_rpl_srh
and gnrc_ipv6_ext
(I'm missing some python module).
Sounds good, all green, so go. |
@haukepetersen Are you interested in the eInk driver support? I started playing around with an epaper display from gooddisplay. |
@Citrullin yes, that would be very interesting. I personally won't however have much time to spend on this, but maybe there is others in the community that would like to collaborate I am sure. |
Contribution description
Phyted and the Zephyr community designed and build this nice board, so it would be a shame not to support RIOT for it :-)
Infos about the board:
If I have seen correctly, there are no RIOT drivers for the HDC1010 (humidity and temperature), ADPS9960 (light), and SSD1673 (e-ink display) devices in RIOT's master. Though I included there pin mappings, one can currently not use them. But hopefully drivers will be available soon.
Everything else should be pretty straight-forward...
Testing procedure
Running the
default
example (useBOARD=reel
) with SAUL gives access to all configured components of the board. Else simply run the complete test-suite and make sure everything passes.Issues/PRs references
none