codacy: disable complaining about python assert #11086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This silents the reported issue in codacy about python asserts:
Use of assert detected. The enclosed code will be removed when
compiling to optimised byte code.
The concern is valid about python asserts, but they are used in tests
and python is not run with optimised byte code.
Solution taken from codacy website
https://support.codacy.com/hc/en-us/articles/207994335-Code-Patterns
2 tasks
|
The solution makes sense. Thanks |
|
Thank you for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This silents the reported issue in codacy about python asserts:
The concern is valid about python asserts, but they are used in tests
and python is not run with optimised byte code.
Solution taken from codacy website
https://support.codacy.com/hc/en-us/articles/207994335-Code-Patterns
Testing procedure
This silents the issue from #10952 (comment) where I now have this commit too.
Issues/PRs references
Found about codacy complains in #10952 (comment)