gnrc_sixlowpan_iphc: fix _compressible() [backport 2019.01] #10954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When either `gnrc_sixlowpan_iphc_nhc` or `gnrc_udp` is not compiled in `_compressible()` never returns `true`. This causes the `dispatch` snip in `gnrc_sixlowpan_iphc_send()` to be of length 0, meaning `dispatch->data` is `NULL`, causing possible crashes when trying to send IPv6 packets over 6LoWPAN without NHC or UDP. (cherry picked from commit 43c2c72)
4 tasks
PeterKietzmann
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
ACK. @aabadie is it okay to merge into release branch right now?
Is there a bug freeze on the release I am not aware of? |
|
Let's merge this PR. As a consequence, we will need a RC3. |
Yepp, I suggest we wait for the merge of the missing backports (and possibly my bugfix for the issue you found in RC2 with native) and then go to RC3 immediately (no need to finish all tests for RC2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10950
Contribution description
When either
gnrc_sixlowpan_iphc_nhcorgnrc_udpis not compiled in_compressible()never returnstrue. This causes thedispatchsnip ingnrc_sixlowpan_iphc_send()to be of length 0, meaningdispatch->dataisNULL, causing possible crashes when trying to send IPv6 packets over 6LoWPAN without NHC or UDP.Testing procedure
tests/gnrc_tcp_serverandtests/gnrc_tcp_clientshould work on a 6Lo-based board.examples/gnrc_networkingshould still be able to exchange UDP packets. Those packets should be compressed with NHC (check with sniffer).Issues/PRs references
Fixes #10947