makefiles/vars.inc.mk: do not export LINKFLAGS #10853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only used by `Makefile.include` and should not be used by sub-make
instances.
This is required to prevent evaluating `LINKFLAGS` when not needed and a
required step to not evaluate it on the host with for example `avr-ld`
when building in docker.
I checked usage with:
git grep -e '(LINKFLAGS)' -e '{LINKFLAGS}'
Packages may be using it but `LINKFLAGS` is a RIOT way of naming
things and even if `generate-xcompile-toolchain` uses `LINK` it does not
use `LINKFLAGS`.
aabadie
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
The provided reason for this change and the change itself make both sense.
I also tested #10854 and also confirm that this PR is fixing the bug (I already noticed it some time ago but didn't understand why it was failing).
The build CI is green, so the change is not introducing any problems.
ACK
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
It is only used by
Makefile.includeand should not be used by sub-makeinstances.
This is required to prevent evaluating
LINKFLAGSwhen not needed and arequired step to not evaluate it on the host with for example
avr-ldwhen building in docker.
I checked usage with:
Packages may be using it but
LINKFLAGSis a RIOT way of namingthings and even if
generate-xcompile-toolchainusesLINKit does notuse
LINKFLAGS.Testing procedure
Look at the usages on
LINKFLAGSwithgit grep -e '(LINKFLAGS)' -e '{LINKFLAGS}'and notice nothing is using it exceptMakefile.includeandmakefiles/info.inc.mk.I did not look in the packages yet but will if the CI build fails.
Issues/PRs references
Found while testing
arduino-mega2560in docker on a machine withoutavrinstalled./bin/sh: 1: avr-ld: not found. It needs another commit to be fixed though that will come in another PR.Main reference on removing exports: #10850